php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #66392 "You're not allowed to add comment on bug #xxxxx"
Submitted: 2014-01-02 20:23 UTC Modified: 2014-02-06 02:59 UTC
From: chealer at gmail dot com Assigned: danielc (profile)
Status: Closed Package: Website problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2014-01-02 20:23 UTC] chealer at gmail dot com 
Description:
------------
When trying to comment on bug #53255, one gets an error:
You're not allowed to add comment on bug #53255

A syntaxically correct equivalent would need a period and a removal of "add" (or addition of a determiner).

In the context of #53255, the intended meaning could be carried with:
You're not allowed to comment on bug #53255.

Depending on the contexts where this message is used, it might be clearer to use:
Comments on bug #xxxxx are restricted.


By the way, a more severe issue is that a contributor may get this error without any warning. The form offers to redact a comment, but then the above error is thrown when selecting "Submit" and the comment is rejected.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-01-03 03:11 UTC] danielc@php.net
-Assigned To: +Assigned To: danielc
 [2014-01-03 03:36 UTC] danielc@php.net
-Status: Assigned +Status: Analyzed -Assigned To: danielc +Assigned To: bjori
 [2014-01-03 03:36 UTC] danielc@php.net 
Ah, turns out I don't have karma on this repository.  Here's a pull request:
https://github.com/php/web-bugs/pull/7
 [2014-01-04 00:00 UTC] bjori@php.net
-Status: Analyzed +Status: Assigned -Assigned To: bjori +Assigned To: danielc
 [2014-01-04 00:00 UTC] bjori@php.net 
You've karma now.
 [2014-02-05 21:20 UTC] danielc@php.net
-Status: Assigned +Status: Closed
 [2014-02-05 21:20 UTC] danielc@php.net 
Various commits made back in early January have now been pushed to the bugs web server.

The message has been clarified.  Also, when comments are disabled, the text area gets replaced by a message saying further comments are unnecessary.

Thanks for your suggestions.
 [2014-02-06 02:51 UTC] chealer at gmail dot com 
Thanks for the deep fix danielc. Note that the form is not quite right when comments are blocked - it still displays "Anyone can comment on a bug." as well as Preview and Submit buttons.
 [2014-02-06 02:59 UTC] chealer at gmail dot com 
I reported that in bug #66652.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Apr 18 18:01:28 2024 UTC