see:  http://marc.info/?l=php-internals&m=136419054303602&w=2

Remi, could you please test with the patches? personally, I prefer the sencode 
one. since it's simple

Sorry for the delay.

Test done with 201303251230 snapshot, and, to ensure file being regenerated
rm Zend/zend_{language,ini}_parser.[ch]
Do you think this is enough ?


Fedora 18, bison 2.6.1: ok.
Fedora 17, bison 2.5.1: ok
RHEL 6.4, bison 2.4.1; HS

/builddir/build/BUILD/php5.5-201303251230/ext/tokenizer/tokenizer_data.c: In function 'tokenizer_register_constants':
/builddir/build/BUILD/php5.5-201303251230/ext/tokenizer/tokenizer_data.c:32: error: 'T_REQUIRE_ONCE' undeclared (first use in this function)
/builddir/build/BUILD/php5.5-201303251230/ext/tokenizer/tokenizer_data.c:32: error: (Each undeclared identifier is reported only once
/builddir/build/BUILD/php5.5-201303251230/ext/tokenizer/tokenizer_data.c:32: error: for each function it appears in.)
/builddir/build/BUILD/php5.5-201303251230/ext/tokenizer/tokenizer_data.c:33: error: 'T_REQUIRE' undeclared (first use in this function)
...

But this seems a parallel build issue, as running a "make" after failue succeed... need more tests.

Sorry for bad previous tests.

Adding, before the build to ensure correct generation
rm Zend/zend_{language,ini}_parser.[ch]
./genfiles

Fedora 18, bison 2.6.1, NTS: ok.
Fedora 18, bison 2.6.1, ZTS: ok.
Fedora 17, bison 2.5.1, NTS: ok
Fedora 17, bison 2.5.1, ZTS: ok
RHEL 6.4,  bison 2.4.1, NTS: ok
RHEL 6.4,  bison 2.4.1, ZTS: ok

So I think you can commit the bison_build_2.patch

What was the bison version used to get this build error?

This bug appears to be present in the latest PHP 5.3.28 release for the same reasons.

This is definitely affecting 5.3.28 tarballs configured with --enable-maintainer-zts on CentOS 5 (at least):

/bin/sh /tmp/php-5.3.28/libtool --silent --preserve-dup-deps --mode=compile /tmp/php-5.3.28/meta_ccld  -Iext/standard/ -I/tmp/php-5.3.28/ext/standard/ -DPHP_ATOM_INC -I/tmp/php-5.3.28/include -I/tmp/php-5.3.28/main -I/tmp/php-5.3.28 -I/tmp/php-5.3.28/ext/date/lib -I/tmp/php-5.3.28/ext/ereg/regex -I/tmp/php-5.3.28/TSRM -I/tmp/php-5.3.28/Zend  -D_REENTRANT  -g -O2 -fvisibility=hidden -pthread -DZTS  -c /tmp/php-5.3.28/ext/standard/basic_functions.c -o ext/standard/basic_functions.lo
In file included from /tmp/php-5.3.28/ext/standard/basic_functions.c:49:
/tmp/php-5.3.28/Zend/zend_language_parser.h:317: error: conflicting types for ‘zendparse’
/tmp/php-5.3.28/Zend/zend_globals_macros.h:35: error: previous declaration of ‘zendparse’ was here
make: *** [ext/standard/basic_functions.lo] Error 1

Laruence, are we able to backport this fix to 5.3 somehow? (I know it bumps the bison version requirement, which isn't ideal — are there any other possibilities?)

I encountered this bug with PHP 5.3.28 on a Gentoo system. I manually applied the patch above together with the bison_any_version.patch from the Gentoo repository to bump to bison 2.7. Works like a charm. :)

5.3 are only security fix now.. so I don't think we should do that..

Note this wasn't a problem in 5.3.27, for that reason I think it should be fixed, or simply the build dependencies for creating the tarballs use the old bison 2.3 process I believe used to be used for this.

Sorry, I mean 2.4.1, which appears to be the version that the PHP 5.3.27 tarball files were generated from.

I am also running into this issue when attempting to compile on RHEL 5 and 6.  I can understand not wanting to make changes to 5.3 since it is now security fixes only, but I can not understand leaving things broken.  The changes to zend don't appear to be connected with the two points in the change log.

Did the follow changes to zend get included by accident?

$ diff -q ./php-5.3.27/Zend/ ./php-5.3.28/Zend/
Files ./php-5.3.27/Zend/acinclude.m4 and ./php-5.3.28/Zend/acinclude.m4 differ
Common subdirectories: ./php-5.3.27/Zend/RFCs and ./php-5.3.28/Zend/RFCs
Common subdirectories: ./php-5.3.27/Zend/tests and ./php-5.3.28/Zend/tests
Only in ./php-5.3.28/Zend/: zend_config.h
Files ./php-5.3.27/Zend/zend_ini_parser.c and ./php-5.3.28/Zend/zend_ini_parser.c differ
Files ./php-5.3.27/Zend/zend_ini_parser.h and ./php-5.3.28/Zend/zend_ini_parser.h differ
Files ./php-5.3.27/Zend/zend_ini_parser.output and ./php-5.3.28/Zend/zend_ini_parser.output differ
Files ./php-5.3.27/Zend/zend_language_parser.c and ./php-5.3.28/Zend/zend_language_parser.c differ
Files ./php-5.3.27/Zend/zend_language_parser.h and ./php-5.3.28/Zend/zend_language_parser.h differ
Files ./php-5.3.27/Zend/zend_language_parser.output and ./php-5.3.28/Zend/zend_language_parser.output differ

-Ben

FYI: same error with make on AIX

        /bin/sh /data/prj/php/php-5.3.28/libtool --silent --preserve-dup-deps --mode=compile xlc_r  -Iext/standard/ -I/data/prj/php/php-5.3.28/ext/standard/ -DPHP_ATOM_INC -I/data/prj/php/php-5.3.28/include -I/data/prj/php/php-5.3.28/main -I/data/prj/php/php-5.3.28 -I/data/prj/php/php-5.3.28/ext/date/lib -I/data/prj/php/php-5.3.28/ext/ereg/regex -I/opt/include/libxml2 -I/opt/include -I/opt/include/freetype2 -I/data/prj/php/php-5.3.28/ext/mbstring/oniguruma -I/data/prj/php/php-5.3.28/ext/mbstring/libmbfl -I/data/prj/php/php-5.3.28/ext/mbstring/libmbfl/mbfl -I/opt/mysql/include -I/data/prj/php/php-5.3.28/ext/sqlite3/libsqlite -I/data/prj/php/php-5.3.28/TSRM -I/data/prj/php/php-5.3.28/Zend  -D_THREAD_SAFE  -I/usr/include -O2 -g -qlanglvl=extc99 -qmaxmem=65536 -I/opt/include -DAIX -DZTS   -c /data/prj/php/php-5.3.28/ext/standard/basic_functions.c -o ext/standard/basic_functions.lo 
"/data/prj/php/php-5.3.28/Zend/zend_language_parser.h", line 317.5: 1506-343 (S) Redeclaration of zendparse differs from previous declaration on line 35 of "/data/prj/php/php-5.3.28/Zend/zend_globals_macros.h".
"/data/prj/php/php-5.3.28/Zend/zend_language_parser.h", line 317.5: 1506-376 (I) Redeclaration of zendparse has a different number of fixed parameters than the previous declaration.
make: 1254-004 The error code from the last command is 1.