php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #39598 error verification after fwrite()
Submitted: 2006-11-22 22:53 UTC Modified: 2006-11-22 23:06 UTC
Votes:10
Avg. Score:5.0 ± 0.0
Reproduced:10 of 10 (100.0%)
Same Version:2 (20.0%)
Same OS:6 (60.0%)
From: max at nucleus dot it Assigned:
Status: Open Package: Feature/Change Request
PHP Version: 5.2.0 OS: Linux
Private report: No CVE-ID:
Have you experienced this issue?
Rate the importance of this bug to you:

 [2006-11-22 22:53 UTC] max at nucleus dot it
Description:
------------
The documentation states tha fwrite() returns false in 
case of error, but it doesn't do so if the actual write 
fails.
For example if I asynchronously write to a pipe (such as 
those obtained by proc_open()) I and the pipe is not ready 
or is broken, fwrite() returns 0.
This could be a correct behaviour it I had a way to 
determine the error.
The problem is that EAGAIN or EPIPE are completely 
impossible to determine and I can't know if I need to wait 
or I have to close the stream.
A possible solution would be to implement ferror() or 
errno.

Reproduce code:
---------------
$Proc = proc_open($Cmd, $Streams, $Pipes, $CWD, $Env);

stream_set_blocking($Pipes[0], 0);

$Result = fwrite($Pipes[0], "test");

// If $Pipes[0] is not ready to receive data
// $Result is 0, but I can't know why.
// The real code I'm writing involves
// stream_select() and repeated reads and writes
// on multiple pipes.

Expected result:
----------------
fwrite() should return 0 when the stream is asynchrounous, 
the C write() returns 0 and errno is EAGAIN.
fwrite() should return false in all other cases where the 
C write() returns 0.

Alternatively a way to access ferror() or errno is needed.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-03-01 00:04 UTC] gauthierm@php.net
Here's a simple reproduce test case:

http://labs.silverorange.com/files/php-bug39598/php-bug-39598-test.phps

In this case, and EPIPE occurs. The fwrite call writes 0 bytes. No error code is 
available and no PHP error is raised.
 [2016-01-22 14:04 UTC] salsi at icosaedro dot it
Missing error detection in streams and filters is a general flaw in the internal i/o handling affecting all the related functions (fopen, fread, fwrite, fflush, fclose) which is really severe, because it affects the safety of any file and data transfer, and would deserve maximum attention and urgency for being fix asap. I may list several other reports that demonstrates missing detection of corrupted file system missing detection of invalid encoded data and so on:

fread() does not detect file access error
https://bugs.php.net/bug.php?id=71384
(Also includes disk image containing a damaged file for testing.)

require* and include* do not detect input/output error
https://bugs.php.net/bug.php?id=71385
(Probably related to the bug above.)

fread() does not detect decoding errors from filter zlib.inflate
https://bugs.php.net/bug.php?id=71417
(Probably missing propagation of errors through streams.)

fread() does not detects decoding errors from filter bzip2.decompress
https://bugs.php.net/bug.php?id=71263
(Probably the same as above.)

All these share the same common denominator: missing error propagation from libc to PHP user's space.
 
PHP Copyright © 2001-2016 The PHP Group
All rights reserved.
Last updated: Tue Sep 27 18:01:49 2016 UTC