php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Return to Bug #68089
Patch fix-url-5.4 revision 2014-09-29 01:07 UTC by stas@php.net
Patch fix-options-5.5 revision 2014-09-29 01:01 UTC by stas@php.net
revision 2014-09-29 00:57 UTC by stas@php.net
revision 2014-09-29 00:56 UTC by stas@php.net
Patch fix-5.5 revision 2014-09-29 00:54 UTC by stas@php.net
Patch bug68089.diff revision 2014-09-25 10:40 UTC by johannes@php.net

Patch fix-options-5.5 for *General Issues Bug #68089

Patch version 2014-09-29 00:57 UTC

Return to Bug #68089 | Download this patch
This patch is obsolete

Obsoleted by patches:

This patch renders other patches obsolete

Obsolete patches:

Patch Revisions:

Developer: stas@php.net

commit 373a219e6a30a082116dd4341c27731d8590e60d
Author: Stanislav Malyshev <stas@php.net>
Date:   Sun Sep 28 17:53:49 2014 -0700

    Fix bug #68089 - do not accept options with embedded \0

diff --git a/ext/curl/interface.c b/ext/curl/interface.c
index 765918c..ac5e20f 100644
--- a/ext/curl/interface.c
+++ b/ext/curl/interface.c
@@ -169,6 +169,11 @@ static int php_curl_option_str(php_curl *ch, long option, const char *str, const
 {
 	CURLcode error = CURLE_OK;
 
+	if (strlen(str) != len) {
+		php_error_docref(NULL TSRMLS_CC, E_WARNING, "Curl option %ld contains invalid characters (\\0)", option);
+		return FAILURE;
+	}
+
 #if LIBCURL_VERSION_NUM >= 0x071100
 	if (make_copy) {
 #endif
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Fri Nov 15 13:01:35 2019 UTC