php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #9878 gmmktime is 1 hour off during standard time
Submitted: 2001-03-20 14:08 UTC Modified: 2001-11-07 09:22 UTC
From: bfoddy at mn dot mediaone dot net Assigned:
Status: Closed Package: Date/time related
PHP Version: 4.0.4pl1 OS: Solaris 2.6
Private report: No CVE-ID:
 [2001-03-20 14:08 UTC] bfoddy at mn dot mediaone dot net
gmmktime is producing a timestamp 1 hour off when the timezone is standard time.  If you compare a 
time() with gmmktime  with current settings and a is_dst
value NULL, the results will be one hour off.

I used the following little script to prove this:
<?
print ("<PRE>");
print ("Time function = ".time ());
print ("\n");
print ("gmmktime = ".gmmktime (18,25,0,3,20,2001));
print ("\n");
print ("mktime = ".mktime(12,25,0,3,20,2001));
print ("\n");
print (gmmktime(7,0,0,4,1,2001)."  ".mktime(1,0,0,4,1,2001)."\n");
print (gmmktime(8,0,0,4,1,2001)."  ".mktime(3,0,0,4,1,2001)."\n");

?>

Currently, the US/Central timezone is -6 hours from GMT.

I believe the problem is in ext/standard/datetime.c, line
186.  Judging from the code, "timezone" seems to be a negative seconds value from GMT, probably of the standard timezone (TZ in standard).  So if is_dst == 0, you don't want to add anything more.  I think the like should say:

gmadjust = -(is_dst ? timezone - 3600 : timezone );

And the comment about overcorrecting removed.

My test script works if this line is changed.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-03-30 10:13 UTC] bfoddy at mn dot mediaone dot net
I know there are a lot of open bugs and this one is probably pretty small compared to most, but the time window to
easily verify this bug and my suggested fix is quickly going
away for 6 months.  With the time shift this weekend, it
wil be much more difficult to reproduce this bug, unless you
start subtracting 86400 seconds per day to get back into standard time.

If someone could just look at what I've provided I think
it will be a no-brainer.  Even if it doesn't get tagged into
the new release, at least it will saved for the next.

Thanks
 [2001-05-05 15:40 UTC] rasmus@php.net
Are you sure that bit of code applies in your case?  ie. is HAVE_TM_GMTOFF undefined in your main/php_config.h file?  I am unable to recreate this problem here, but on my Linux box my gmadjust value comes straight from the libc system call ie. I have HAVE_TM_GMTOFF defined.
 [2001-05-07 12:52 UTC] derick@php.net
Waiting for feedback on Rasmus' question.
 [2001-05-07 14:10 UTC] bfoddy at mn dot mediaone dot net
Sorry, I replied to the email, but it didn't get logged to
the record.

Yes I'm sure Solaris2.6 does not have the tm_gmtoff value in 
tm struct.  Linux does, perhaps newer Solaris do also, I
don't know.  But definately 2.6 does not have the value
so the config does not set the HAVE_TM_GMTOF defined.

I supposed to test on Linux you could rebuild php and
override this define.

If its any help, we are using the patch I suggested on a
production Solaris server and it worked fine on both
sides of the time shift in April.
 [2001-07-13 10:50 UTC] bfoddy at mn dot mediaone dot net
Can we try to get this patch in 4.0.7?  Its not as critical
an issue during the summer, but the standard time will
be here before you know it.
 [2001-10-21 21:07 UTC] sniper@php.net
Missing status.

 [2001-11-07 09:22 UTC] jmoore@php.net
Fixed in CVS
 [2002-01-18 15:29 UTC] bfoddy at mn dot mediaone dot net
This fix did NOT get into 4.1.1 as advertised;  I just
checked the 4.1.1 source I downloaded.
Can someone double check
how it was missed and if its in the CVS for the next
release?  Otherwise I can reopen it.

Thanks,
Brian
 
PHP Copyright © 2001-2014 The PHP Group
All rights reserved.
Last updated: Sun Apr 20 08:02:33 2014 UTC