|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
[2001-02-21 12:24 UTC] andrei@php.net
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Wed Nov 05 10:00:02 2025 UTC |
Both array_push() and array_unshift() leak memory when called with a non-array first parameter (which generates an error, of course) For example: <? $abc = 0; for($i=0; $i<5000000; $i++) { @array_push($abc, 123); } ?> Patch follows... --- php-4.0.4pl1/ext/standard/array.c.ORIG Wed Feb 21 09:07:13 2001 +++ php-4.0.4pl1/ext/standard/array.c Wed Feb 21 08:59:59 2001 @@ -1501,6 +1501,7 @@ stack = *args[0]; if (Z_TYPE_P(stack) != IS_ARRAY) { php_error(E_WARNING, "First argument to array_push() needs to be an array"); + efree(args); RETURN_FALSE; } @@ -1605,6 +1606,7 @@ stack = *args[0]; if (Z_TYPE_P(stack) != IS_ARRAY) { php_error(E_WARNING, "First argument to array_unshift() needs to be an array"); + efree(args); RETURN_FALSE; }