php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #9328 ext/pgsql/php_pgsql.h needs to include postgres_fe.h not postgres.h
Submitted: 2001-02-18 17:37 UTC Modified: 2001-02-19 03:16 UTC
From: ler at lerctr dot org Assigned:
Status: Closed Package: PostgreSQL related
PHP Version: 4.0.4pl1 OS: UnixWare 7.1.1
Private report: No CVE-ID: None
View Developer Edit
 [2001-02-18 17:37 UTC] ler at lerctr dot org 

Starting with PostgreSQL 7.1beta5 (or current CVS), PHP's pgsql
extension needs to only include <postgres_fe.h> to compile. 

Here is a patch:

Index: php_pgsql.h
===================================================================
RCS file: /cvsroot/php/ext/pgsql/php_pgsql.h,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 php_pgsql.h
*** php_pgsql.h 2000/12/23 23:05:41     1.1.1.2
--- php_pgsql.h 2001/02/18 21:15:45
***************
*** 29,35 ****
  
  #ifdef PHP_PGSQL_PRIVATE
  #undef SOCKET_SIZE_TYPE
! #include <postgres.h>
  #include <libpq-fe.h>
  
  #ifdef PHP_WIN32
--- 29,35 ----
  
  #ifdef PHP_PGSQL_PRIVATE
  #undef SOCKET_SIZE_TYPE
! #include <postgres_fe.h>
  #include <libpq-fe.h>
  
  #ifdef PHP_WIN32
-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

$

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-02-18 17:59 UTC] ler at lerctr dot org 
Actually, you don't need EITHER file. 

Here is a new patch against 4.0.4pl1:
$ cvs diff -c -rREL_4_0_4pl1   
cvs diff: Diffing .
Index: php_pgsql.h
===================================================================
RCS file: /cvsroot/php/ext/pgsql/php_pgsql.h,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 php_pgsql.h
*** php_pgsql.h 2000/12/23 23:05:41     1.1.1.2
--- php_pgsql.h 2001/02/18 22:57:20
***************
*** 29,35 ****
  
  #ifdef PHP_PGSQL_PRIVATE
  #undef SOCKET_SIZE_TYPE
- #include <postgres.h>
  #include <libpq-fe.h>
  
  #ifdef PHP_WIN32
--- 29,34 ----
$
 [2001-02-19 03:16 UTC] sas@php.net 
Fixed in CVS. Thanks for your report.
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Wed May 07 16:01:30 2025 UTC