php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #81120 PGO data for main PHP DLL are not used
Submitted: 2021-06-09 17:31 UTC Modified: 2021-06-09 23:03 UTC
From: cmb@php.net Assigned: cmb (profile)
Status: Closed Package: *Compile Issues
PHP Version: 8.0.7 OS: Windows
Private report: No CVE-ID: None
 [2021-06-09 17:31 UTC] cmb@php.net
Description:
------------
The main PHP DLL is named php8.dll (or php8ts.dll etc.) as of PHP
8.0.0, but the PGP compile step is still looking for php7!*.pgc
and php7.pgd, what effectively disables the most relevant
profile-guided optimizations.

Test script:
---------------
configure --with-pgo && nmake

Expected result:
----------------
No warnings; profile-guided optimizations should be enabled.

Actual result:
--------------
PGOMGR : warning PG0188: No .PGC files matching 'D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7!*.pgc' were found.
  Reading PGD file 1: D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7.pgd
D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7.pgd(0) : warning C4961: No profile data was merged into 'D:\a\php-ftw\php-ftw\php\vs16\x64\obj\Release\php7.pgd', profile-guided optimizations disabled


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-06-09 17:31 UTC] cmb@php.net
-Assigned To: +Assigned To: cmb
 [2021-06-09 23:03 UTC] cmb@php.net
Actually, the PGO trainig already merges the .pgc files into the
.pgd files, so these warnings are expected and harmless.
 [2021-06-10 21:00 UTC] git@php.net
Automatic comment on behalf of cmb69
Revision: https://github.com/php/php-src/commit/21f2ff79de674744e12f713eb59f2e6bf8a7b769
Log: Fix #81120: PGO data for main PHP DLL are not used
 [2021-06-10 21:00 UTC] git@php.net
-Status: Assigned +Status: Closed
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Fri Jul 30 18:01:30 2021 UTC