php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #80684 Make bug "Closes" action more strict for bugs.php.net bugtrack
Submitted: 2021-01-28 19:12 UTC Modified: 2021-01-28 22:33 UTC
From: ae@php.net Assigned:
Status: Open Package: *General Issues
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: ae@php.net
New email:
PHP Version: OS:

 

 [2021-01-28 19:12 UTC] ae@php.net
Description:
------------
A commit message with "Closes php/doc-pt_br#3" correctly closes the respective issue on GitHub doc mirror, but also try to close a bugs.php.net bug. See transcript bellow:

---

Commit:    dd831989aec8cc8f6ed5682f2f7f02e62b909352
Parents:   6be11c70ce382a1edb06c2084072c6857df04797
Branches:  master

Link:       http://git.php.net/?p=doc/pt_br.git;a=commitdiff;h=dd831989aec8cc8f6ed5682f2f7f02e62b909352

Log:
Update translation

Closes php/doc-pt_br#3

Bugs:
https://bugs.php.net/3

Expected result:
----------------
No mention of "Bugs:" or "https://bugs.php.net/"

Actual result:
--------------
Trying to re-closes a ancient bugs.php.net.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2021-01-28 22:33 UTC] cmb@php.net
I agree that the hash sign followed by a number anywhere in the
commit message should generally not close a bug ticket, but at
least in this case you could have just used

    Closes GH-3.

There is no need to mention the repo, or write a hash sign. :)
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Sat Apr 17 20:01:23 2021 UTC