php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #80531 call_user_func_array() interprets string keys as named args
Submitted: 2020-12-18 09:43 UTC Modified: 2020-12-18 09:46 UTC
From: rh at tfli dot co dot uk Assigned:
Status: Open Package: Scripting Engine problem
PHP Version: 8.0.0 OS: Windows 10 (64Bit)
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: rh at tfli dot co dot uk
New email:
PHP Version: OS:

 

 [2020-12-18 09:43 UTC] rh at tfli dot co dot uk
Description:
------------
This might be expected behaviour, but if so, should be made clear in the migration guide and/or the function page.

Since upgrading to PHP8, then an unchanged call to call_user_func_array in an existing project was returning the error 'Uncaught Error: Cannot use positional argument after named argument'. Investigating it further, one of the arguments is de-serialised from a JSON object (and so the array has string keys).

While I can see the behaviour of `call_user_func_array` using string keys as named arguments being useful, I can also see it being a massive 'gotta' for people when upgrading, especially as it is not currently documented anywhere that this will be the case (a lot of the times this can happen the array internal structure won't be apparent from the code or the error message).

Test script:
---------------
<?php
var_dump(call_user_func_array("strlen", ["hello"]));
var_dump(call_user_func_array("strlen", ["a" => "hello"]));

// Version Comparison: https://3v4l.org/c1R03

Expected result:
----------------
int(5)
int(5)

Actual result:
--------------
int(5)

Fatal error: Uncaught Error: Unknown named parameter $a in /in/c1R03:3
Stack trace:
#0 {main}
  thrown in /in/c1R03 on line 3

Process exited with code 255.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-12-18 09:46 UTC] nikic@php.net
-Summary: Crash in mysqlnd_fetch_stmt_row_cursor when calling an SP with a cursor +Summary: call_user_func_array() interprets string keys as named args -Type: Bug +Type: Documentation Problem
 [2020-12-18 09:46 UTC] nikic@php.net
This is documented in the migration guide (https://www.php.net/manual/en/migration80.incompatible.php):

> call_user_func_array() array keys will now be interpreted as parameter names, instead of being silently ignored.

However, it is not yet mentioned in the call_user_func_array() documentation itself.
 [2020-12-18 09:50 UTC] rh at tfli dot co dot uk
Ah, right you are! I did do a search for `named` (in relation to named arguments) before reporting the bug; and I did read through the full guide when upgrading.
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Mon May 10 19:01:24 2021 UTC