php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Doc Bug #80502 Comparison of empty string to 0
Submitted: 2020-12-10 12:18 UTC Modified: 2020-12-10 12:49 UTC
Votes:1
Avg. Score:4.0 ± 0.0
Reproduced:0 of 1 (0.0%)
From: craig at craigfrancis dot co dot uk Assigned:
Status: Verified Package: *General Issues
PHP Version: 8.0.0 OS: N/A
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: craig at craigfrancis dot co dot uk
New email:
PHP Version: OS:

 

 [2020-12-10 12:18 UTC] craig at craigfrancis dot co dot uk 
Description:
------------
Maybe related to RFC "string_to_number_comparison"?

In PHP 7 the comparison ('' < 0) would convert the empty string to 0, then return false.

But in PHP 8.0.0, the empty string is now considered less-than 0?

Common issue for HTML forms, which provide all values as strings, and a blank number field is effectively seen as 0 - e.g. entering a time with separate fields (hours and minutes), and the user does not enter a value in the seconds field... yes, you could cast the value to an integer, but a lot of websites out there don't.

Test script:
---------------
var_export([
    (''  < 0),
    ('1' < 0),
    ('0' < 0),
  ]);

Expected result:
----------------
array ( 0 => false, 1 => false, 2 => false, )

Actual result:
--------------
array ( 0 => true, 1 => false, 2 => false, )

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-12-10 12:27 UTC] craig at craigfrancis dot co dot uk 
And the same with ('' == 0)... PHP 7 this would be true, PHP 8 it's false.

While I appreciate that's supposed to be false with ('' === 0), the double equals comparison operator is supposed to be equal "after type juggling".
 [2020-12-10 12:49 UTC] cmb@php.net
-Status: Open +Status: Verified
 [2020-12-10 12:49 UTC] cmb@php.net 
Yes, that is indeed a consequence of that RFC.  Since the empty
string is not a well-formed numeric string, a string comparison is
done, and the empty string is less than any other string.  The
migration guide should not only mention == comparision, but the
other affected operations as well.  And of course the respective
documentation in the manual proper needs to be updated.
 [2020-12-10 12:49 UTC] cmb@php.net
-Type: Bug +Type: Documentation Problem
 [2020-12-10 14:21 UTC] craig at craigfrancis dot co dot uk 
https://www.php.net/manual/en/language.operators.comparison.php

Operand 1: string, resource, int or float
Operand 2: string, resource, int or float
Result: Translate strings and resources to numbers, usual math

I have a horrible feeling this change is going to cause issues, as PHP is typically working with user input from web forms, where the GET/POST values provided are strings, same with many other sources (e.g. fgetcsv).
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved. 		Last updated: Thu Mar 04 15:01:24 2021 UTC