PHP :: Doc Bug #80059 :: Lowercase true/false should be used in code examples

Lowercase true/false should be used in code examples

Submitted:

2020-09-04 11:51 UTC

Modified:

2020-09-04 12:26 UTC

Votes:	1
Avg. Score:	5.0 ± 0.0
Reproduced:	1 of 1 (100.0%)
Same Version:	1 (100.0%)
Same OS:	1 (100.0%)

From:

t dot motylewski at gmail dot com

Assigned:

Status:

Verified

Package:

Documentation problem

PHP Version:

Irrelevant

OS:

Private report:

CVE-ID:

None

[2020-09-04 11:51 UTC] t dot motylewski at gmail dot com

Description:
------------
---
From manual page: https://php.net/language.types.boolean
---

According to PSR, boolean values should be written lowercase, eg.

$foo = false; 

and not 

$foo = FLASE;

Right now in many places in docs uppercase values are used, which confuses new users.

Patches

Pull Requests

History

[2020-09-04 12:00 UTC] cmb@php.net

-Status: Open +Status: Verified

[2020-09-04 12:00 UTC] cmb@php.net

> According to PSR, […]

PSR is irrelevant for the code examples in the PHP manual, since
these are supposed to follow the PEAR CS[1]; however, PEAR CS also
mandates that true, false and null must always be lowercase[2].

[1] <http://doc.php.net/tutorial/style.php>
[2] <https://pear.php.net/manual/en/standards.naming.php>

[2020-09-04 12:26 UTC] t dot motylewski at gmail dot com

Thanks for the quick verification.
Its quite surprising that docs are not using PSR. I've created a separate ticket for this topic https://bugs.php.net/bug.php?id=80060

[2022-04-28 16:21 UTC] kinggorghenry at yahoo dot com

The following pull request has been associated:

Patch Name: Ignore externally managed and generated files
On GitHub:  https://github.com/php/web-windows/pull/21
Patch:      https://github.com/php/web-windows/pull/21.patch

[2022-04-28 16:36 UTC] maghsodid at yahoo dot com

The following pull request has been associated:

Patch Name: Prepare for longer commit hashes
On GitHub:  https://github.com/php/web-windows/pull/24
Patch:      https://github.com/php/web-windows/pull/24.patch

[2022-04-28 16:38 UTC] maghsodid at yahoo dot com

The following pull request has been associated:

Patch Name: Fix issue with pt_BR not being updated
On GitHub:  https://github.com/php/systems/pull/15
Patch:      https://github.com/php/systems/pull/15.patch

	php.net \| support \| documentation \| report a bug \| advanced search \| search howto \| statistics \| random bug \| login
go to bug id or search bugs for


Copyright © 2001-2024 The PHP Group All rights reserved.	Last updated: Fri Apr 19 08:01:28 2024 UTC