php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #79350 Classes with __toString() do not support early binding
Submitted: 2020-03-07 04:12 UTC Modified: 2021-07-23 09:29 UTC
Votes:1
Avg. Score:4.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: bugreports at gmail dot com Assigned:
Status: Analyzed Package: Scripting Engine problem
PHP Version: master-Git-2020-03-07 (Git) OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Have you experienced this issue?
Rate the importance of this bug to you:

 [2020-03-07 04:12 UTC] bugreports at gmail dot com 
Description:
------------

this is only broken with PHP 8.0-dev for some time now and it's technically not possible that a class defined in the include above the extending definition is not found

require_once __DIR__ . '/PelEntry.php';
class PelEntryUndefined extends PelEntry
{
}


[builduser@testserver:/rpmbuild/SPECS]$ /home/builduser/rpmbuild/BUILD/php-8.0.0/sapi/cli/php -n /www/php-bug/test.php
Fatal error: Uncaught Error: Class 'PelEntry' not found in /Volumes/dune/www-servers/php-bug/pel/PelEntryUndefined.php:59
Stack trace:
#0 /Volumes/dune/www-servers/php-bug/pel/PelIfd.php(44): require_once()
#1 /Volumes/dune/www-servers/php-bug/pel/PelTag.php(45): require_once('/Volumes/dune/w...')
#2 /Volumes/dune/www-servers/php-bug/pel/PelEntry.php(52): require_once('/Volumes/dune/w...')
#3 /Volumes/dune/www-servers/php-bug/pel/PelExif.php(47): require_once('/Volumes/dune/w...')
#4 /Volumes/dune/www-servers/php-bug/pel/PelJpeg.php(49): require_once('/Volumes/dune/w...')
#5 /Volumes/dune/www-servers/php-bug/test.php(2): include_once('/Volumes/dune/w...')
#6 {main}
  thrown in /Volumes/dune/www-servers/php-bug/pel/PelEntryUndefined.php on line 59

Test script:
---------------
tarball with the (i know outdated) pel-library and the simplest reproducer which works in 7.0-7.4 but no longer with HEAD

https://drive.google.com/file/d/1stClmJ92hp1ZbDNbRYOGyu3FXn0ktRbI/view?usp=sharing

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-03-12 10:09 UTC] nikic@php.net
-Status: Open +Status: Verified
 [2020-03-12 10:09 UTC] nikic@php.net 
I think something is going wrong with a recursive require_once.
 [2020-03-12 10:22 UTC] nikic@php.net 
No, that's not it. I think the issue is that this code is relying on early binding, and early-binding on the PelEntry class is now prevented due to implicit addition of Stringable interface.
 [2020-03-12 10:29 UTC] nikic@php.net
-Status: Verified +Status: Analyzed
 [2020-03-12 10:29 UTC] nikic@php.net 
Here's a reduced test case:

<?php
  
echo new Test, "\n";

class Test {
    public function __toString() {
        echo "Early bound!";
    }
}
 [2020-03-12 10:51 UTC] bugreports at gmail dot com 
sounds like a terrible BC break and at least the error message is unhelpful nonsense given that even one of the zend engine experts pointed at include at the first try :-)
 [2021-07-23 09:29 UTC] nikic@php.net
-Summary: 8.0-dev: Uncaught Error: Class 'PelEntry' not found +Summary: Classes with __toString() do not support early binding
 [2021-07-23 09:30 UTC] nikic@php.net 
Related To: Bug #81224
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved. 		Last updated: Sat Jul 24 16:01:23 2021 UTC