php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #79026 change EXTRA_VERSION in 7.4 no longer works
Submitted: 2019-12-24 08:48 UTC Modified: 2019-12-24 10:47 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:0 (0.0%)
Same OS:0 (0.0%)
From: bugreports at gmail dot com Assigned:
Status: Closed Package: *Configuration Issues
PHP Version: 7.4Git-2019-12-24 (Git) OS: Linux
Private report: No CVE-ID: None
 [2019-12-24 08:48 UTC] bugreports at gmail dot com
Description:
------------
this works "fine" in 7.2/7.3 but no longer with 7.4 to get buildinfos into "php -v"

sed -i -E 's/EXTRA_VERSION=".*"/EXTRA_VERSION="-%{versionsuffix}-fc%{fedora}"/' configure

the configure (at least generated with "touch configure.ac; ./buildconf --force" is nearly 100k lines long with 20 or more functions called main which makes it a mess find out what changed

why can't that stuff not just read PHP_EXTRA_VERSION from a environment variable?




Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-12-24 10:35 UTC] cmb@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: cmb
 [2019-12-24 10:35 UTC] cmb@php.net
Wouldn't it be an option for you to adjust the version number in
configure.ac[1] according to your needs?

[1] <https://github.com/php/php-src/blob/php-7.4.1/configure.ac#L20>
 [2019-12-24 10:40 UTC] bugreports at gmail dot com
well, i found at least a solutuin which works but it#s somehow hack to begin with wen we have ./configure and need to hack around in files

touch configure.ac
./buildconf --force
# add vendor-suffix to version and replace dev/rc/alpha/beta
sed -i -E 's/EXTRA_VERSION=".*"/EXTRA_VERSION="-%{versionsuffix}-fc%{fedora}"/' configure
sed -i -E 's/PHP_EXTRA_VERSION=\$4/PHP_EXTRA_VERSION=-%{versionsuffix}-fc%{fedora}/' configure
 [2019-12-24 10:47 UTC] cmb@php.net
-Status: Feedback +Status: Open -Type: Bug +Type: Feature/Change Request -Assigned To: cmb +Assigned To:
 [2019-12-24 10:47 UTC] cmb@php.net
Well, then switching to feature request, since I don't think this
qualifies as bug.
 [2023-07-14 13:54 UTC] athoscribeiro at gmail dot com
I filed a PR with a fix proposal for this one at https://github.com/php/php-src/pull/11706
 [2023-07-19 10:15 UTC] git@php.net
Automatic comment on behalf of athos-ribeiro (author) and petk (committer)
Revision: https://github.com/php/php-src/commit/d35df89c357dafdfc383e1272c4121a416ac3482
Log: Fix #79026: Allow PHP_EXTRA_VERSION overrides
 [2023-07-19 10:15 UTC] git@php.net
-Status: Open +Status: Closed
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Wed Dec 11 23:01:27 2024 UTC