php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78604 token_get_all() does not properly tokenize FOO<?php with short_open_tag=0
Submitted: 2019-09-28 14:09 UTC Modified: 2019-09-28 15:55 UTC
From: tandre@php.net Assigned: nikic (profile)
Status: Closed Package: Scripting Engine problem
PHP Version: 7.4.0RC2 OS:
Private report: No CVE-ID: None
 [2019-09-28 14:09 UTC] tandre@php.net
Description:
------------
Note that this happened for me when php was configured with short tags, both for the latest php 7.4 and 8.0 (e.g. this is what travis/compile.sh would do)

ext/tokenizer/tests/php_tag_only.phpt would fail if php.ini had short_open_tags=0

tested with php 7.4 NTS, ZTS, and php 8.0 NTS (compiled within the last month)

Test script:
---------------
» php --no-php-ini  -d short_open_tag=0 -a                   
Interactive shell

php > var_export(token_get_all('FOO<?php'));
array (
  0 => 
  array (
    0 => 313,
    1 => 'FOO<?php',
    2 => 1,
  ),
)
php > echo PHP_VERSION;
7.4.0-dev


Expected result:
----------------
Outputs two tokens, one for FOO, and one for <?php

Actual result:
--------------
Outputs a single token with FOO<?php

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-09-28 14:50 UTC] tandre@php.net
Evaluation is also affected

» php --no-php-ini  -d short_open_tag=0 -a
Interactive shell

php > eval('?>FOO<?php');
FOO<?php
 [2019-09-28 15:54 UTC] requinix@php.net
-Package: Testing related +Package: Scripting Engine problem -Assigned To: +Assigned To: nikic
 [2019-09-30 08:43 UTC] nikic@php.net
Automatic comment on behalf of nikita.ppv@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=19e7e4b19717d0b66c0aad39992c5d98e62bf10e
Log: Fixed bug #78604
 [2019-09-30 08:43 UTC] nikic@php.net
-Status: Assigned +Status: Closed
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Tue Oct 22 13:01:29 2019 UTC