php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78551 Iteration Failures
Submitted: 2019-09-16 18:39 UTC Modified: 2019-11-25 13:13 UTC
From: v-altruo at microsoft dot com Assigned: cmb (profile)
Status: Re-Opened Package: Testing related
PHP Version: 7.4.0RC1 OS: Windows Server 2012 R2
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2019-09-16 18:39 UTC] v-altruo at microsoft dot com
Description:
------------
Test fails for both x64/x86 and NTS/TS builds regardless of opcache on/off. 
This test also failed for 7.2.23RC1 and 7.3.10RC1.

Failed Test Location: ext\standard\tests\file\windows_acls\bug44859_4.phpt

Expected result:
----------------
Testing file with relative path:
Iteration #1: passed.
Iteration #2: passed.
Iteration #3: passed.
Iteration #4: passed.
Testing directory with relative path:
Iteration #1: passed.
Iteration #2: passed.
Iteration #3: passed.
Iteration #4: passed.

Actual result:
--------------
Testing file with relative path:
Iteration #1: passed.
Iteration #2: passed.
Iteration #3: passed.
Iteration #4: passed.
Testing directory with relative path:
Iteration #1: passed.
Iteration #2: bool(true)
bool(false)
failed.
Iteration #3: bool(true)
bool(false)
failed.
Iteration #4: passed.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-09-17 07:31 UTC] cmb@php.net
-Assigned To: +Assigned To: cmb
 [2019-09-17 07:31 UTC] cmb@php.net
I cannot reproduce this test failure.  I can imagine that the
failure is caused by one or more of the exec() calls in
ext\standard\tests\file\windows_acls\common.inc failing.  For
debugging it might be useful to add an exec() wrapper to that
file:

    function my_exec($cmd) {
        $res = exec($cmd, $output, $status);
        if ($status) {
            echo "FAILED: $cmd\n";
        }
        return $res;
    }

And to replace all exec() calls in common.inc with my_exec().
Could you please check that?
 [2019-09-17 07:51 UTC] cmb@php.net
-Status: Assigned +Status: Feedback
 [2019-09-17 17:56 UTC] v-altruo at microsoft dot com
-Status: Feedback +Status: Assigned
 [2019-09-17 17:56 UTC] v-altruo at microsoft dot com
After making those changes (tested on 7.2.23RC1), the output is still the same: 

Testing file with relative path:
Iteration #1: passed.
Iteration #2: passed.
Iteration #3: passed.
Iteration #4: passed.
Testing directory with relative path:
Iteration #1: passed.
Iteration #2: bool(true)
bool(false)
failed.
Iteration #3: bool(true)
bool(false)
failed.
Iteration #4: passed.
 [2019-11-04 09:44 UTC] cmb@php.net
While I still have not been able to reproduce this locally, I've
seen this test occasionally failing on AppVeyor (same diff), so
there might be some execution order issue.
 [2019-11-09 13:01 UTC] cmb@php.net
-Status: Assigned +Status: Feedback
 [2019-11-09 13:01 UTC] cmb@php.net
Fabien just committed a potential fix[1] for this issue (PHP 7.4).
Can you please check whether this would solve the issue for you?

[1] <http://git.php.net/?p=php-src.git;a=commit;h=ce41795a9f7eac181e6ac38daf3964fc7eb822e2>
 [2019-11-17 04:22 UTC] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
 [2019-11-18 14:41 UTC] cmb@php.net
-Status: No Feedback +Status: Re-Opened
 [2019-11-18 14:41 UTC] cmb@php.net
Re-opening, to not forget about this ticket.  For now, it seems
that Fabien's patch indeed fixed the issue, but lets wait a while
before backporting.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Sun Dec 08 00:01:26 2019 UTC