go to bug id or search bugs for
Hi Guys, i think there's a small issue with how DateTime object works and it can be made much better with just a very small change. So now when you're using timestamp in constructor or in DateTime::CreateFromFormat then php silently ommits specified timezone. Same thing happens when you include timezone in the time itself, and also specify it - then timezone contained in time string has preference.
This is documented, but very counter-intuitive. So in case where the object gets created with different timezone than specified in $timezone parameter it would be great to include a warning.
// Example 1
$tz = new DateTimeZone('America/New_York');
$time_o = new DateTime('@'.time(), $tz);
// Example 2
$time_o = DateTime::CreateFromFormat("U", time(), $tz);
Add 2 warnings, depending on case.
1. Warning: DateTime object created from timestamp, timezone forced to UTC (ignoring America/New_York) in line 2
2. Warning: CreateFromFormat has timezone specified both in $time and in $timezone, ignoring $timezone in line 1
PHP is silently ignoring optional function parameter specified by user. Which is counter intuitive, because if someone specifies time and timezone he's probably counting on that time to be presented in timezone given, despite the format.
Other action which would make it better is to always honor $timezone first. Because many people find this confusing that the parameter gets ignored in DateTime documentation. But this could break existing code and probably is much harder to implement so just a warning would be great...
Add a Patch
Add a Pull Request
As this adds warnings this would need to be for PHP 8 as it is a BC break, not sure this needs an RFC so assign to derick which maintains the datetime extension.
From php 5.2.1 it is possible to use the time zone, not to create warnings generated because the utility of this function setTimeZome is modified specifically for DateTimeZone
$tz1 = new DateTimeZone('UTC');
$timestamp = time();
$time_1 = new DateTime('@'.$timestamp);
$tz2 = new DateTimeZone('America/New_York');
$time_2 = new DateTime('@'.$timestamp);
Output Never Notice or Warnings here.