php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78349 Bundled pcre2 library missing LICENCE file
Submitted: 2019-07-29 14:56 UTC Modified: 2019-07-29 15:55 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: rainer dot jung at kippdata dot de Assigned: petk (profile)
Status: Assigned Package: PCRE related
PHP Version: 7.4.0beta1 OS: Any
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2019-07-29 14:56 UTC] rainer dot jung at kippdata dot de
Description:
------------
In PHP 7.3 and 7.4 the bundled pcrelib was updated from PCRE 1 to PCRE 2. When updating, all non-code files were dropped, expecially the LICENCE file. I think it would be better to add the upstream PCRE 2 LICENCE file back and maybe also the other ones:

AUTHORS
ChangeLog
COPYING
HACKING
INSTALL
LICENCE
NEWS
NON-AUTOTOOLS-BUILD
README
doc

The loss might be due to the fact, that in PCRE 1 source file were located in the top directory, just as these accompanying files, in PCRE 2 they are located in a sub folder "src", so just syncing the src folder misses the accompanying files.


Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-07-29 15:25 UTC] nikic@php.net
-Type: Documentation Problem +Type: Bug
 [2019-07-29 15:27 UTC] cmb@php.net
The license is already contained in README.REDIST.BINS[1].
Not sure what to do regarding the other files.

[1] <https://github.com/php/php-src/blob/php-7.4.0beta1/README.REDIST.BINS#L23-L116>
 [2019-07-29 15:48 UTC] rainer dot jung at kippdata dot de
Ah, had not seen that. For me the licence was the critical file. I think the other files are less critial. I don't know what mechanism is used to sync the bundled pcre2 lib with upstreams. It might be easy to include those files in the sync (if it is not done manually). But if you like you can also close this ticket.

Thanks!
 [2019-07-29 15:54 UTC] petk@php.net
Hello, also a more relevant linkage for the pcre library is noted in the CONTRIBUTING.md file where to send upstream patches. The LICENSE file can and should be added back probably, yes since it is a "standard" one and copy of it should most likely be included besides the README file in the project root.

Regarding the other doc files and contributing info, they will be outdated soon and are basically more like an inconsistent noise from the php-src point of view. They should be included also to support the upstream library and its authors?
 [2019-07-29 15:55 UTC] petk@php.net
-Assigned To: +Assigned To: petk
 [2019-07-29 17:17 UTC] petk@php.net
The following pull request has been associated:

Patch Name: Fix #78349: Bundled pcre2 library missing LICENCE file
On GitHub:  https://github.com/php/php-src/pull/4483
Patch:      https://github.com/php/php-src/pull/4483.patch
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Tue Aug 20 14:01:47 2019 UTC