php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #78348 Remove -lrt from pdo_sqlite.so because fdatasync removed in 5.3
Submitted: 2019-07-29 12:07 UTC Modified: 2019-07-29 15:58 UTC
From: rainer dot jung at kippdata dot de Assigned: petk (profile)
Status: Closed Package: PDO SQLite
PHP Version: 7.4.0beta1 OS: Solaris
Private report: No CVE-ID: None
 [2019-07-29 12:07 UTC] rainer dot jung at kippdata dot de
Description:
------------
PDO SQLite still contains the following configure test in its config.m4:

  dnl Solaris fix
  PHP_CHECK_LIBRARY(rt, fdatasync, [PHP_ADD_LIBRARY(rt,, PDO_SQLITE_SHARED_LIBADD)])

This check can be dropped, because the fdatasync was only used inside the bundled sqlite, but starting with 5.3 sqlite is no longer bundled but expected as an external dependency. So libsqlite3.so itself would have that dependency, but the pdo-sqlite.so extension should not have an entry for -lrt any more.

You can simply drop the two lines from ext/pdo_sqlite/config.m4 (and regenerate configure).

This applies to any PHP version starting with 5.3 and up until 7.4beta1.

Note that older bugs are about fdatasync being used but -lrt missing. This is about fdatasync no longer being used but -lrt still present.


Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-07-29 13:13 UTC] cmb@php.net
While ext/pdo_sqlite/sqlite/* is removed as of PHP 5.3.0,
pdo_sqlite defaults to using ext/sqlite3/libsqlite/* (the latter
is only removed as of PHP 7.4.0), where -lrt *might* still be
needed.
 [2019-07-29 14:34 UTC] rainer dot jung at kippdata dot de
You are right!
So dropping for 7.4 is save and you can keep it as is in 7.2/7.3. It is just a minor cleanup. Having the rt lib as an unneeded dependency is not critical, but removing complexity is always nice (for 7.4).
 [2019-07-29 15:58 UTC] petk@php.net
-Assigned To: +Assigned To: petk
 [2019-07-29 19:17 UTC] petk@php.net
The following pull request has been associated:

Patch Name: Fix #78348: Remove -lrt from pdo_sqlite.so
On GitHub:  https://github.com/php/php-src/pull/4485
Patch:      https://github.com/php/php-src/pull/4485.patch
 [2019-07-30 20:09 UTC] petk@php.net
Automatic comment on behalf of peterkokot@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=09b108246a8c1277d37b3d6c0ac6e5544f88d317
Log: Fix #78348: Remove -lrt from pdo_sqlite.so
 [2019-07-30 20:09 UTC] petk@php.net
-Status: Assigned +Status: Closed
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Mon Dec 09 05:01:26 2019 UTC