php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #77725 Mention of PHP 4 and Zend Engine 1 with variable references
Submitted: 2019-03-11 19:00 UTC Modified: 2019-03-24 19:50 UTC
From: girgias@php.net Assigned: girgias (profile)
Status: Closed Package: *General Issues
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2019-03-11 19:00 UTC] girgias@php.net
Description:
------------
---
From manual page: https://php.net/language.variables.scope
---
When talking about references with global and static [1] there is a mention of PHP 4 and Zend Engine 1 which is pretty outdated information.
However, I don't know how to rephrase it or if the section should be removed.

[1] https://secure.php.net/manual/en/language.variables.scope.php#language.variables.scope.references


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-03-11 19:50 UTC] requinix@php.net
-Summary: Mention of PHP 4 and Zend Engine 1 +Summary: Mention of PHP 4 and Zend Engine 1 with variable references -Package: PHP Language Specification +Package: *General Issues
 [2019-03-11 19:50 UTC] requinix@php.net
PHP 4 has been/is being removed from the manual. That whole section should be checked to make sure it's still correct for PHP 7, and of course edited a bit.
 [2019-03-11 22:34 UTC] kalle@php.net
-Status: Open +Status: Feedback
 [2019-03-11 22:34 UTC] kalle@php.net
"PHP implements the static and global modifier for variables..."

Something along those lines is how I would phrase it
 [2019-03-11 22:49 UTC] girgias@php.net
-Status: Feedback +Status: Open
 [2019-03-11 22:49 UTC] girgias@php.net
Huh, seems reasonable to write it like that Kalle.
Will go on and update my current patch for it.
 [2019-03-11 22:55 UTC] girgias@php.net
Updated my patch at http://edit.php.net/?patchID=3314&project=PHP
to include the fix for this.
 [2019-03-13 09:56 UTC] kalle@php.net
I reviewed the patch;

The patches seems to make the assumption that arrays like $HTTP_POST_VARS is PHP4 only, This is not the case as they were available after the introduction of superglobals like $_POST in 4.1.0 all the way to their deprecation in 5.3.0. Check the register_long_arrays ini directive, which I removed in 5.4.0.

(Just assign me if you need more comments as I am not subscribed to bug reports)

Thanks =D
 [2019-03-13 14:51 UTC] girgias@php.net
-Assigned To: +Assigned To: kalle
 [2019-03-13 14:51 UTC] girgias@php.net
Hey Kalle updated the patch may you have another look at it (still the same link http://edit.php.net/?patchID=3314&project=PHP)

And if you have time could you have a look at another, larger, patch that removes notions of PHP 4 and PHP 5.0.0? http://edit.php.net/?patchID=3282&project=PHP

Cheers
 [2019-03-19 14:55 UTC] girgias@php.net
Ping @kalle, anytime during the week?
 [2019-03-23 20:53 UTC] kalle@php.net
-Assigned To: kalle +Assigned To: girgias
 [2019-03-23 20:53 UTC] kalle@php.net
Sorry it took so long, I reviewed the patch in the editor and it looks good, feel free to commit it, just make sure it validates.

I tried to commit it but it said there was some update error and I'm not that familiar with the editor interface so I cannnot tell what is going on.
 [2019-03-23 20:59 UTC] girgias@php.net
-Assigned To: girgias +Assigned To: kalle
 [2019-03-23 20:59 UTC] girgias@php.net
Thanks for looking at it however I don't have the required Karma to commit to the English Documentation.

Maybe I should ask for it, or can you grant it to me?
 [2019-03-23 21:01 UTC] kalle@php.net
Hi, I just asked Nikita to grant you karma as I don't have SVNROOT karma, alternatively try ping Salathe@ and ask him for the karma for doc-en :)
 [2019-03-23 21:05 UTC] girgias@php.net
Okay great :)
Will wait until Monday before pinging someone else.

Thanks for everything :)
 [2019-03-24 19:49 UTC] girgias@php.net
Automatic comment from SVN on behalf of girgias
Revision: http://svn.php.net/viewvc/?view=revision&revision=347045
Log: Removed various notions about PHP 4 in variable language spec;
Fix Doc Bug #77725
 [2019-03-24 19:50 UTC] girgias@php.net
-Status: Assigned +Status: Closed -Assigned To: kalle +Assigned To: girgias
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Sun Jun 16 18:01:27 2019 UTC