php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #77642 typo "incompatibe" in Zend/zend_compile.c
Submitted: 2019-02-20 15:37 UTC Modified: 2019-02-20 18:49 UTC
From: divinity76 at gmail dot com Assigned: cmb (profile)
Status: Closed Package: Scripting Engine problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2019-02-20 15:37 UTC] divinity76 at gmail dot com 
Description:
------------
the word "incompatible" was accidentally written as "incompatibe"

guilty commit: 7e597f48e9fda982e930e4f617d2b2d98d8878a5

file: Zend/zend_compile.c

line: 4134 when introduced, 3933 in current git-master

github links: 
https://github.com/php/php-src/blob/7e597f48e9fda982e930e4f617d2b2d98d8878a5/Zend/zend_compile.c#L4134

https://github.com/php/php-src/blob/master/Zend/zend_compile.c#L3933

version: 7.2.14-dev when introduced, still unfixed as of 7.4-dev

Patches

zend_compile.diff (last revision 2019-02-20 15:37 UTC by divinity76 at gmail dot com)

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2019-02-20 15:40 UTC] 
The following pull request has been associated:

Patch Name: fix #77642: typo "incompatibe" in Zend/zend_compile.c
On GitHub:  https://github.com/php/php-src/pull/3866
Patch:      https://github.com/php/php-src/pull/3866.patch
 [2019-02-20 16:09 UTC] salathe@php.net
-Type: Documentation Problem +Type: Bug -Package: *General Issues +Package: Scripting Engine problem
 [2019-02-20 18:41 UTC] cmb@php.net 
Automatic comment on behalf of divinity76@gmail.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=876369bea2bad3dca5677b3d8fb144061e2b4145
Log: fix #77642: typo "incompatibe" in Zend/zend_compile.c [ci skip]
 [2019-02-20 18:41 UTC] cmb@php.net
-Status: Open +Status: Closed
 [2019-02-20 18:43 UTC] cmb@php.net
-Assigned To: +Assigned To: cmb
 [2019-02-20 18:49 UTC] nikic@php.net 
For the record, it's not necessary to open a bug report for typo fixes, it's okay to just directly send a PR :)
 [2019-02-20 19:57 UTC] divinity76 at gmail dot com 
@nikic i thought so, but after reading 

> Bug fixes do not require an RFC, but require a bugtracker ticket. Always open a ticket at https://bugs.php.net and reference the bug id using #NNNNNN.


- i made one anyway just to be on the safe side, guess i won't do it next time :p (if there is a next time)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 19 13:01:30 2024 UTC