Example on 3v4l: https://3v4l.org/97X3q

Your example doesn't show __get, it shows __test, which can be correctly used like this https://3v4l.org/M8BtH

Hi,

I'm quite confused by your example, in particular:

i) Your code doesn't include __get, which is what I think you were reporting.

ii) The code in your example works the same on 7.3 as previous versions of PHP - https://3v4l.org/97X3q

iii) What I think you're reporting, does work on 7.3: https://3v4l.org/5p6u3

Please can you clarify what you're reporting.

My mistake, I did mistype the code I was using to reproduce this in immediate mode, and using the correct method name does indeed fix it.

However, in my actual code that is using the magic methods, it's not working on 7.3, but is working on 7.2 and 7.1.  You can see a failing build here: https://travis-ci.org/BapCat/Propifier/builds/474430892

Code is here: https://github.com/BapCat/Propifier/blob/master/src/PropifierTrait.php#L206
Failing test is here: https://github.com/BapCat/Propifier/blob/master/tests/PropifierTraitTest.php#L25

The trait takes protected methods (like getXyz() and/or setXyz()) and turns them into strongly-typed properties (like $obj->xyz).

I don't believe it's a bug in the code, since it runs normally on 7.1/7.2 (and was running fine on earlier versions before adding type hints, etc.)

I think it's worth noting that if I change the name of the private variable to something different than the magic method name, it starts working.

e.g.
// This does not work
private $test;

protected function getTest() {
  return $this->test;
}
//

// This DOES work
private $_test;

protected function getTest() {
  return $this->_test;
}
//

what about provide a tiny *standalone* but *complete* reproducer starting with <?php and ending with ?>

Okay, here we go, found a simple reproduction.

https://3v4l.org/0OAve

Looks like in 7.3, the __set method from the trait isn't being called at all.

Thanks for providing the simplified reproduce case. I tested locally and the code works currently in current 7.3 snapshot -- this bug has been fixed in bug #77291 and will be part of PHP 7.3.1.