php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76921 ArrayAccess only supports increment on by-ref offsetGet()
Submitted: 2018-09-23 14:11 UTC Modified: -
From: nikic@php.net Assigned:
Status: Open Package: Scripting Engine problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: nikic@php.net
New email:
PHP Version: OS:

 

 [2018-09-23 14:11 UTC] nikic@php.net
Description:
------------
Overloaded properties implement $x->y++ by calling __set('y', __get('y') + 1). 

The same does not work for ArrayAccess. ArrayAccess only supports $x[0]++ if offsetGet() returns by reference, in which case the increment is performed on the reference.

This is inconsistent both with the overloaded property behavior and with compound assignment operations on ArrayAccess. That is, $x[0] += 1 *does* work with a by-value offsetGet().

Test script:
---------------
<?php

class Test implements ArrayAccess {
    public function __get($k) {
        return 1;
    }
    public function __set($k, $v) {
        echo "__set($v)\n";
    }
    
    public function offsetGet($k) {
        return 1;
    }
    public function offsetSet($k, $v) {
        echo "offsetSet($v)\n";
    }
    public function offsetExists($k) {}
    public function offsetUnset($k) {}
}

$t = new Test;
echo "Property:\n";
$t->x++;
echo "Offset:\n";
$t[0]++;

Expected result:
----------------
Property:
__set(2)
Offset:
offsetSet(2)

Actual result:
--------------
Property:
__set(2)
Offset:
Notice: Indirect modification of overloaded element of Test has no effect

Patches

Add a Patch

Pull Requests

Add a Pull Request

 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Fri Jan 17 21:01:24 2020 UTC