php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76723 Zip extension tests aren't being running in GCOV
Submitted: 2018-08-09 00:52 UTC Modified: 2018-08-09 11:32 UTC
From: carusogabriel@php.net Assigned: nlopess (profile)
Status: Closed Package: Testing related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2018-08-09 00:52 UTC] carusogabriel@php.net
Description:
------------
Recently, during some tests clean up, I've fixed some SKIPIF sections in our tests, and due to this work (http://gcov.php.net/viewer.php?version=PHP_HEAD&func=skip&file=ext%2Ffileinfo%2Ftests%2Ffinfo_file_stream_001.phpt), I noticed that we aren't running our Zip extension tests in GCOV. 

The `--enable-zip` flag is missing during our configuration: http://gcov.php.net/viewer.php?version=PHP_HEAD&func=system.

Is there a specific reason why we don't run them there? In contrast, we do run them in our CIs, Travis (http://git.php.net/?p=php-src.git;a=blob;f=travis/compile.sh;hb=HEAD#l47) for example.

I've already reported to internals@ (http://news.php.net/php.internals/103053), but I believe here at bugs.php.net is a better place to discuss and track this issue.

Thanks


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-08-09 11:04 UTC] cmb@php.net
-Status: Open +Status: Verified -Assigned To: +Assigned To: nlopess
 [2018-08-09 11:04 UTC] cmb@php.net
The actual configuration doesn't appear to be part of the repo[1],
so likely has to be changed on the box directly.

It might be sensible to add `--enable-zip --without-libzip` to
force using the bundled libzip.

Nuno, could you please have a look at this?

[1] <http://git.php.net/?p=web/gcov.git;a=summary>
 [2018-08-09 11:32 UTC] nlopess@php.net
-Status: Verified +Status: Closed
 [2018-08-09 11:32 UTC] nlopess@php.net
Done: enabled for PHP 7.3 & HEAD, where it was disabled. Thanks for the heads up!
Will pick up the new configs on the next build.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Mon Oct 14 06:01:26 2019 UTC