php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76664 Regression in URL rewrite when JavaScript href?
Submitted: 2018-07-25 16:56 UTC Modified: 2018-07-26 08:49 UTC
Votes:1
Avg. Score:1.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: nicolas dot dermine at gmail dot com Assigned:
Status: Verified Package: Output Control
PHP Version: 7.2.8 OS: linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: nicolas dot dermine at gmail dot com
New email:
PHP Version: OS:

 

 [2018-07-25 16:56 UTC] nicolas dot dermine at gmail dot com
Description:
------------
We output some HTML markup inside a json_encoded string, with double quotes replaced by `\u0022` (with the `JSON_HEX_QUOT` flag)

the HTML markup contains a `<a href="javascript:...>` link

which becomes `<a href=\u0022javascript:...>` when json_encoded

we also use `output_add_rewrite_var`, and had no problem when using PHP 5.6 or PHP 7.0
(i.e .the parameter was not added, since this a JavaScript call, not a URL),

but it seems since PHP 7.1.0 the URL parameter is added just before the first argument of the JavaScript function in the `href` attribute, resulting in a JavaScript error when it is clicked.



Test script:
---------------
<?php
// tried this on https://3v4l.org/fmRvE

output_add_rewrite_var('param_name', 'param_value');
ini_set('url_rewriter.tags', 'a=href');
echo '"<a href=\\u0022javascript:someFunc(\'some arg\')\\u0022>link 2</a>"';

Expected result:
----------------
Output for 5.6.30, 7.0.30 - 7.0.31
"<a href=\u0022javascript:someFunc('some arg')\u0022>link 2</a>"

Actual result:
--------------
Output for 7.1.0 - 7.3.0alpha4
"<a href=\u0022javascript:someFunc(?param_name=param_value'some arg')\u0022>link 2</a>"



(the added `?param_name=param_value` after the opening parenthesis causes a JavaScript error when the link is clicked.)

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-07-26 08:49 UTC] cmb@php.net
-Status: Open +Status: Verified
 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Sun Dec 16 07:01:25 2018 UTC