PHP :: Bug #76268 :: stream_get_contents fail to seek on streams modified by curl_exec
php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76268 stream_get_contents fail to seek on streams modified by curl_exec
Submitted: 2018-04-25 14:35 UTC Modified: -
From: divinity76 at gmail dot com Assigned:
Status: Open Package: cURL related
PHP Version: 7.1.16 OS: linux, debian 10 x64 k4.15.11-1
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2018-04-25 14:35 UTC] divinity76 at gmail dot com
Description:
------------
stream_get_contents fail to seek on streams exclusively modified by curl_exec, the optional third parameter of stream_get_contents is "Seek to the specified offset", and is effectively ignored when the stream has only been modified by curl_exec. 

my best guess is that libcurl calls fwrite directly, and doesn't update php's own stream->position, and stream_get_contents in turn doesn't call fseek if it's not necessary (presumably to save up on syscalls), and determines if it's necessary by checking stream->positioun instead of ftell (presumably to save up on syscalls), then it calls fread() until EOF, which is where libcurl left it, and thus returns an empty string.

Test script:
---------------
<?php
$ch = curl_init ( "http://gstatic.com/generate_204" );
$h = tmpfile ();
curl_setopt_array ( $ch, array (
		CURLOPT_VERBOSE => 1,
		CURLOPT_STDERR => $h 
) );
curl_exec ( $ch );
$verbose1 = stream_get_contents ( $h, - 1, 0 ); // empty string 
fseek ( $h, 0, SEEK_SET ); // a manual fseek fixes it
$verbose2 = stream_get_contents ( $h, - 1, 0 ); // the actual CURLOPT_VERBOSE log
var_dump ( $verbose1 === $verbose2 );


Expected result:
----------------
bool(true)

Actual result:
--------------
bool(false)

Patches

Add a Patch

Pull Requests

Add a Pull Request

 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Thu Aug 16 07:01:24 2018 UTC