php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #75963 ssdeep package incompatible with PHP 7+
Submitted: 2018-02-14 21:08 UTC Modified: 2020-12-20 04:22 UTC
Votes:5
Avg. Score:3.4 ± 1.5
Reproduced:3 of 3 (100.0%)
Same Version:2 (66.7%)
Same OS:2 (66.7%)
From: andras dot iklody at circl dot lu Assigned: treffynnon (profile)
Status: No Feedback Package: ssdeep (PECL)
PHP Version: 7.0.27 OS: Ubuntu 16.04
Private report: No CVE-ID: None
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: andras dot iklody at circl dot lu
New email:
PHP Version: OS:

 

 [2018-02-14 21:08 UTC] andras dot iklody at circl dot lu
Description:
------------
make fails due to RETURN_STRING() expecting 1 parameter (2 provided). This issue affects php 7.x.

Removing the second parameter allows the installation of the package.

Test script:
---------------
Patched the installation, replaced:

RETURN_STRING(hash, 0);

with 

RETURN_STRING(hash);

in both occurrences. 


Patches

php7_upgrade (last revision 2018-02-15 00:04 UTC by andras dot iklody at circl dot lu)
DestinyCloudFist (last revision 2018-02-14 21:09 UTC by andras dot iklody at circl dot lu)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-02-15 00:06 UTC] andras dot iklody at circl dot lu
Further testing showed that the package was incompatible with PHP 7 due to the char[] parameter length being expected to be passed as int, as it was in PHP < 7. Since PHP 7.0 size_t is passed along.

The php7_upgrade patch resolves this.
 [2018-02-15 00:27 UTC] ab@php.net
Looks like you use an older ext version. The latest is PHP 7 compatible.

Thanks.
 [2018-02-15 00:29 UTC] andras dot iklody at circl dot lu
-Summary: Cannot install package due to the changes in RETURN_STRING() +Summary: ssdeep package incompatible with PHP 7+
 [2018-02-15 00:29 UTC] andras dot iklody at circl dot lu
Updated summary to be more representative of the issue.
 [2018-02-19 10:40 UTC] andras dot iklody at circl dot lu
>Looks like you use an older ext version. The latest is PHP 7 compatible.

>Thanks.

Could you point us to the newest version? Took 1.0.4 from here:

https://pecl.php.net/package/ssdeep
 [2018-02-19 14:25 UTC] ab@php.net
Oh, indeed, the fixed version is unreleased yet. See ssdeep master.

Thanks.
 [2018-02-19 23:03 UTC] treffynnon@php.net
I thought a release had been made after those changes, apologies I'll put together a release and update this ticket when it's available.
 [2018-02-20 02:41 UTC] treffynnon@php.net
I've prepared a release and tagged it. Unfortunately, it looks like pecl.php.net is currently down so I cannot publish the release just yet. Will update when it's available.
 [2018-02-20 08:08 UTC] andras dot iklody at circl dot lu
Thanks a million, looking forward to the release!
 [2018-02-20 23:02 UTC] treffynnon@php.net
OK, looks like the release is now available. Please give it a go and feedback on how it goes here.
 [2020-12-07 12:29 UTC] cmb@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: treffynnon
 [2020-12-20 04:22 UTC] pecl-dev at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Sun Jun 20 23:01:23 2021 UTC