php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #75940 Unnecessary compile wrapper with PHP_THREAD_SAFETY=yes
Submitted: 2018-02-08 21:47 UTC Modified: 2018-02-08 21:49 UTC
From: jdolecek at NetBSD dot org Assigned:
Status: Closed Package: *Compile Issues
PHP Version: 7.2.2 OS: NetBSD, pkgsrc
Private report: No CVE-ID: None
View Developer Edit
 [2018-02-08 21:47 UTC] jdolecek at NetBSD dot org 
Description:
------------
NetBSD package system pkgsrc maintains several patches, which we'd like to feed upstream. This is one of them.

If PHP_THREADS_SAFETY is enabled, and there are some pthread flags to add, configure script creates a meta_ccld wrapper and changes compiler to that.

It's way simpler to simply adjust CPPFLAGS, and it also help builds which use compiler wrappers, since they don't know how to deal with 'meta_ccld'.

The wrapper code was added in 2000-03-18 in rev 827ad656cb2, apparently to defeat libtool. The patch shouldn't be really relevant any more.

Patches

php-compile-drop-meta_ccld.diff (last revision 2018-02-08 21:48 UTC by jdolecek at NetBSD dot org)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-02-08 21:49 UTC] jdolecek at NetBSD dot org 
The last sentence should have been "The wrapper code shouldn't really be relevant any more"
 [2018-02-09 13:33 UTC] ab@php.net 
Automatic comment on behalf of jdolecek@NetBSD.org
Revision: http://git.php.net/?p=php-src.git;a=commit;h=a5b55416f4bf48e475b30bb86b120c83efccca53
Log: Fixed bug #75940 Unnecessary compile wrapper with PHP_THREAD_SAFETY=yes
 [2018-02-09 13:33 UTC] ab@php.net
-Status: Open +Status: Closed
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun Dec 22 08:01:29 2024 UTC