php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #75195 DateTimeInterface does not include add method
Submitted: 2017-09-12 17:06 UTC Modified: 2017-09-29 14:49 UTC
Votes:4
Avg. Score:3.8 ± 0.8
Reproduced:2 of 2 (100.0%)
Same Version:2 (100.0%)
Same OS:2 (100.0%)
From: richard dot carree dot com at gmail dot com Assigned:
Status: Open Package: Date/time related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Have you experienced this issue?
Rate the importance of this bug to you:

 [2017-09-12 17:06 UTC] richard dot carree dot com at gmail dot com 
Description:
------------
Both of DateTime and DateTimeInterface expose `add` method. As "DateTimeInterface is meant so that both DateTime and DateTimeImmutable can be type hinted for", why it does not include `add` method?

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-09-12 17:08 UTC] richard dot carree dot com at gmail dot com 
Sorry, I meant:

Both of DateTime and DateTimeImmutable expose `add` method. As "DateTimeInterface is meant so that both DateTime and DateTimeImmutable can be type hinted for", why it does not include `add` method?
 [2017-09-29 09:05 UTC] heiglandreas@php.net 
I wouldn't want to have it included in the interface as the implementation between both is different. Datetime returns itself, while DateTimeImmutable returns a new instance of Datetimeimmutable. So technically the return value is not the same…
 [2017-09-29 14:49 UTC] richard dot carree dot com at gmail dot com 
Both return an object that implements DateTimeInterface.

Couldn't we have something like the following?

```
    /**
     * @return \DateTimeInterface
     */
    public function add(DateInterval $interval); 
```
 
PHP Copyright © 2001-2018 The PHP Group
All rights reserved. 		Last updated: Thu Jun 21 11:01:49 2018 UTC