php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #75042 run-tests.php issues with EXTENSION block on windows
Submitted: 2017-08-06 21:50 UTC Modified: 2017-08-18 22:35 UTC
From: jbboehr@php.net Assigned: ab
Status: Closed Package: Testing related
PHP Version: 7.2.0beta2 OS: Windows 10
Private report: No CVE-ID:
 [2017-08-06 21:50 UTC] jbboehr@php.net
Description:
------------
There are a few issues with using the EXTENSION block in phpt on windows.

1) Commands are not properly escaped for windows. This causes a parse error and the error output to be attempted to be included in following commands as an argument.
2) Extensions to be loaded need the "php_" prefix on Windows.
3) Specifying "-n" to check loaded modules causes "Module already loaded"
warning. This causes the tests to fail (at least on windows) due to the extra output.

Please see my attached patch.

Test script:
---------------
Reproduction is a bit tricky. The latest commit as of now (046ab3a) in this branch can reproduce the issue:
https://github.com/jbboehr/php-handlebars/tree/windows
https://ci.appveyor.com/project/jbboehr/php-handlebars/build/windows.7/job/35ge6iux3k0xa8kb#L2468

But I believe the issue can be reproduced by simply using EXTENSION in a phpt on windows.


Patches

run-tests-windows-extension-r2.patch (last revision 2017-08-07 06:37 UTC) by jbboehr@php.net)
run-tests-windows-extension.patch (last revision 2017-08-06 21:50 UTC) by jbboehr@php.net)

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-08-06 21:50 UTC] jbboehr@php.net
The following patch has been added/updated:

Patch Name: run-tests-windows-extension.patch
Revision:   1502056217
URL:        https://bugs.php.net/patch-display.php?bug=75042&patch=run-tests-windows-extension.patch&revision=1502056217
 [2017-08-06 22:58 UTC] derick@php.net
I'm relatively certain that I added that "-n" for a good reason.
 [2017-08-06 23:10 UTC] jbboehr@php.net
Sorry, after reviewing, I believe that one may be an issue with my setup. I will revert that and update the PR.

The only thing I don't understand is why that is run with -n but the tests aren't also invoked with it.
 [2017-08-07 06:37 UTC] jbboehr@php.net
The following patch has been added/updated:

Patch Name: run-tests-windows-extension-r2.patch
Revision:   1502087845
URL:        https://bugs.php.net/patch-display.php?bug=75042&patch=run-tests-windows-extension-r2.patch&revision=1502087845
 [2017-08-18 22:35 UTC] ab@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: ab
 [2017-08-18 22:35 UTC] ab@php.net
PR merged into 7.2 and might be yet backported.

Thanks.
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Tue Aug 29 15:01:52 2017 UTC