php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #74094 Too strict checks when using CLI SAPI
Submitted: 2017-02-13 18:01 UTC Modified: 2021-03-19 18:40 UTC
From: yunosh@php.net Assigned:
Status: Suspended Package: Session related
PHP Version: master-Git-2017-02-13 (Git) OS:
Private report: No CVE-ID: None
View Developer Edit
 [2017-02-13 18:01 UTC] yunosh@php.net 
Description:
------------
When using the CLI SAPI, it doesn't make sense to implement the same strict HTTP header checks like in webserver SAPIs IMO. There are no headers sent in this case, so the error messages are at least misleading.
As a consequence, it makes unit testing of session related code impossible, because unit testing frameworks usually produce output before even running a single test.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-02-13 18:04 UTC] yunosh@php.net 
This can be seen in real life here: https://travis-ci.org/horde/horde/jobs/201207489#L1860
 [2017-02-21 10:44 UTC] yunosh@php.net 
I wonder if SG(request_info).no_headers should be set to 1 in the CLI SAPI.
 [2021-03-19 18:40 UTC] cmb@php.net
-Status: Open +Status: Suspended -Type: Bug +Type: Feature/Change Request
 [2021-03-19 18:40 UTC] cmb@php.net 
> When using the CLI SAPI, it doesn't make sense to implement the
> same strict HTTP header checks like in webserver SAPIs IMO.

Well, what about the built-in Webserver?

> As a consequence, it makes unit testing of session related code
> impossible, because unit testing frameworks usually produce output
> before even running a single test.

What about stubbing/mocking the functions?

Anyhow, I don't regard the current behavior as a bug, and any
possible change would require discussion on the internals mailing
list.  If you're still interested in this change, please pursue
the RFC process[1].  For the time being, I suspend this ticket.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Mon Dec 30 14:01:28 2024 UTC