php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #73855 Imagick::textureImage documentation and annotation are wrong
Submitted: 2017-01-03 10:38 UTC Modified: 2017-02-07 23:38 UTC
From: gregoire dot daussin at gmail dot com Assigned: danack (profile)
Status: Closed Package: imagick (PECL)
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2017-01-03 10:38 UTC] gregoire dot daussin at gmail dot com
Description:
------------
---
From manual page: http://www.php.net/imagick.textureimage
---
Both online documentation and in-code annotation are wrong about the return value.  
It does not return TRUE as stated but the new imagick object.  
Either fix the documentation and the annotations, or even better fix the return value to return TRUE and update the source object like other functions.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-01-03 12:12 UTC] cmb@php.net
-Package: Documentation problem +Package: imagick
 [2017-01-11 05:02 UTC] krakjoe@php.net
-Assigned To: +Assigned To: danack
 [2017-01-11 05:02 UTC] krakjoe@php.net
Dan assigning to you: Can you take a quick look at this please ?
 [2017-02-07 02:00 UTC] gabriel dot jean at outlook dot com
This is the normal behavior of the MagickWand api (see https://www.imagemagick.org/api/magick-image.php#MagickTextureImage)

Made a quick patch for the doc:
http://edit.php.net/?patchID=2363&project=PHP
 [2017-02-07 23:38 UTC] danack@php.net
-Status: Assigned +Status: Closed
 [2017-02-07 23:38 UTC] danack@php.net
gabriel thanks for the patch.

gregoire, the documentation will be updated in a few days when its build process runs.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Apr 25 22:01:29 2024 UTC