php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #72836 integer overflow in base64_decode caused heap corruption
Submitted: 2016-08-15 04:08 UTC Modified: 2017-02-13 01:46 UTC
From: minhrau dot vc dot 365 at gmail dot com Assigned: stas
Status: Closed Package: *General Issues
PHP Version: 5.6.24 OS: ALL
Private report: No CVE-ID:
 [2016-08-15 04:08 UTC] minhrau dot vc dot 365 at gmail dot com
Description:
------------
In php_base64_encode function, the safe_emalloc did not check value it alloc for string, which used to store the result of base64 encode function. This cause the length of string after encode > INT_MAX and caused the heap corruption some where else (example in this case is in chunk_split function)

PHPAPI unsigned char *php_base64_encode(const unsigned char *str, int length, int *ret_length) /* {{{ */
{
	const unsigned char *current = str;
	unsigned char *p;
	unsigned char *result;

	if (length < 0) {
		if (ret_length != NULL) {
			*ret_length = 0;
		}
		return NULL;
	}

	result = (unsigned char *) safe_emalloc((length + 2) / 3, 4 * sizeof(char), 1);  //<- muse check size of safe_emalloc here, must be < MAX_INT
	p = result;

Test script:
---------------
<?php

ini_set('memory_limit', -1);

$a = str_repeat('#', 0xffffffff/2-5);
var_dump(strlen($a));
$str1 = base64_encode($a);  
 
var_dump(strlen($str1));
chunk_split($str1, 11, $str1);
?>


Expected result:
----------------
No Crash

Actual result:
--------------
Starting program: /home/minhrau/PHP-5.6.24/sapi/cli/php testbase64encode_negativelength.php
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
int(2147483642)
int(-1431655772)

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff49ebfd7 in __memcpy_avx_unaligned () from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff49ebfd7 in __memcpy_avx_unaligned () from /usr/lib/libc.so.6
#1  0x000000000067c14f in zif_chunk_split (ht=<optimized out>, return_value=0x7ffff7fa8158, return_value_ptr=<optimized out>, this_ptr=<optimized out>, return_value_used=<optimized out>) at /home/minhrau/PHP-5.6.24/ext/standard/string.c:2221
#2  0x00000000007c4c9d in zend_do_fcall_common_helper_SPEC (execute_data=<optimized out>) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:558
#3  0x000000000074f75e in execute_ex (execute_data=0x7ffff7f73260) at /home/minhrau/PHP-5.6.24/Zend/zend_vm_execute.h:363
#4  0x000000000071a951 in zend_execute_scripts (type=type@entry=8, retval=retval@entry=0x0, file_count=file_count@entry=3) at /home/minhrau/PHP-5.6.24/Zend/zend.c:1341
#5  0x00000000006b8ce0 in php_execute_script (primary_file=primary_file@entry=0x7fffffffd0e0) at /home/minhrau/PHP-5.6.24/main/main.c:2613
#6  0x00000000007c66a7 in do_cli (argc=2, argv=0xf27d50) at /home/minhrau/PHP-5.6.24/sapi/cli/php_cli.c:994
#7  0x000000000042b8a4 in main (argc=2, argv=0xf27d50) at /home/minhrau/PHP-5.6.24/sapi/cli/php_cli.c:1378

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-08-15 06:14 UTC] stas@php.net
-PHP Version: 5.6Git-2016-08-15 (Git) +PHP Version: 5.6.24 -Assigned To: +Assigned To: stas
 [2016-08-15 06:16 UTC] stas@php.net
-Type: Bug +Type: Security -Private report: No +Private report: Yes
 [2016-08-17 05:57 UTC] stas@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d6a43a8562ec58043fa5e26f2a58b0c239feee40
Log: Fix bug #72836 - integer overflow in base64_decode caused heap corruption
 [2016-08-17 05:57 UTC] stas@php.net
-Status: Assigned +Status: Closed
 [2016-08-17 08:23 UTC] stas@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d6a43a8562ec58043fa5e26f2a58b0c239feee40
Log: Fix bug #72836 - integer overflow in base64_decode caused heap corruption
 [2016-08-17 09:15 UTC] laruence@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d6a43a8562ec58043fa5e26f2a58b0c239feee40
Log: Fix bug #72836 - integer overflow in base64_decode caused heap corruption
 [2016-08-18 11:15 UTC] tyrael@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f973877a2f8d58b857f0f02b8a88a2ee05a1cbb0
Log: Fix bug #72836 - integer overflow in base64_decode caused heap corruption
 [2016-10-17 10:09 UTC] bwoebi@php.net
Automatic comment on behalf of stas
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d6a43a8562ec58043fa5e26f2a58b0c239feee40
Log: Fix bug #72836 - integer overflow in base64_decode caused heap corruption
 [2017-02-13 01:46 UTC] stas@php.net
-Type: Security +Type: Bug
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Wed Feb 22 06:01:36 2017 UTC