php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #72554 ftbfs - buffio.h renamed to tidybuffio.h
Submitted: 2016-07-06 15:48 UTC Modified: 2016-07-11 12:46 UTC
Votes:2
Avg. Score:4.0 ± 1.0
Reproduced:1 of 1 (100.0%)
Same Version:0 (0.0%)
Same OS:0 (0.0%)
From: l dot declercq at nuxwin dot com Assigned: cmb (profile)
Status: Closed Package: Tidy (PECL)
PHP Version: 7.0.8 OS: Any
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If this is not your bug, you can add a comment by following this link.
If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: l dot declercq at nuxwin dot com
New email:
PHP Version: OS:

 

 [2016-07-06 15:48 UTC] l dot declercq at nuxwin dot com 
Description:
------------
We get build failure with latest tidy-html5 due to buffio.h header that has been renamed to tidybuffio.h.

I provided a patch for PHP 5.6.23 here: https://github.com/htacg/tidy-html5/issues/235

Basically, with this patch, old and new version of tidy developement library is supported.

Patches

ftbsf_tidy.patch (last revision 2016-07-06 15:55 UTC by l dot declercq at nuxwin dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-07-06 19:10 UTC] cmb@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: cmb
 [2016-07-06 19:10 UTC] cmb@php.net 
Thanks! Note that there is already a respective PR[1], which also
fixes several tests. Could you please verify the PR?

[1] <https://github.com/php/php-src/pull/1940>
 [2016-07-06 19:27 UTC] l dot declercq at nuxwin dot com
-Status: Feedback +Status: Assigned
 [2016-07-06 19:27 UTC] l dot declercq at nuxwin dot com 
Well, it seem that I like to complicate my life. My patch is another way to do what is done here https://github.com/php/php-src/pull/1940/commits/b7076c4579ad2d0cc61dc52221bcfdd2012105a1

I'll have a look at the whole PR ;)
 [2016-07-08 15:12 UTC] jpauli@php.net 
Please, review https://github.com/php/php-src/pull/1940 , I was about to merge it, but prefer waiting for a review if you can do it.
 [2016-07-08 18:59 UTC] cmb@php.net 
I'll check it out ASAP, but still hoping that l dot declercq also
will. :)
 [2016-07-11 12:40 UTC] ab@php.net
-Status: Assigned +Status: Closed
 [2016-07-11 12:40 UTC] ab@php.net 
PR #1940 is merged with 7.1.

Thanks.
 [2016-07-11 12:46 UTC] cmb@php.net
-Type: Bug +Type: Feature/Change Request
 [2016-07-12 17:51 UTC] ab@php.net 
Related To: Bug #72379
 
PHP Copyright © 2001-2022 The PHP Group
All rights reserved. 		Last updated: Fri May 27 15:03:39 2022 UTC