php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #72224 Optimize reflection initialization
Submitted: 2016-05-16 14:18 UTC Modified: 2016-05-29 10:04 UTC
Votes:6
Avg. Score:4.7 ± 0.7
Reproduced:6 of 6 (100.0%)
Same Version:2 (33.3%)
Same OS:0 (0.0%)
From: dmri87 at hotmail dot com Assigned:
Status: Open Package: Reflection related
PHP Version: 7.0.7RC1 OS:
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2016-05-16 14:18 UTC] dmri87 at hotmail dot com
Description:
------------
PHP should improve the creation of Reflection objects.

Almost literally any library or framework using Reflection non trivially I've encountered implements its own Reflection objects caching mechanism. That because creating such objects is incredibly expensive and it's way more expensive than caching them all, even if thousands of them. I had to do the same to keep performance acceptable.

PHP should do this internally if possible, or try to optimize something, because again, the amount of times I've seen this is incredible and it's a clear sign the creation of such object is just too slow.

Just to be clear (sorry if I sound harsh but I actually just want to be clear) Reflection object's creation performance is a problem even for those that are using it trivially. I don't think it's acceptable if the creation of few dozens of these objects turns out to be an important bottleneck for applications that would otherwise be extremely fast.

Thank you for reading and double thank you if you intend to work on this.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-05-20 19:29 UTC] krakjoe@php.net
-Status: Open +Status: Feedback
 [2016-05-20 19:29 UTC] krakjoe@php.net
I've flicked through the source code of the most common reflector constructors, and I see nothing that is obviously causing such problems.

Can you provide some example code that behaves extra ordinarily, perhaps that will help me to understand better ?
 [2016-05-23 20:03 UTC] dmri87 at hotmail dot com
Literally any reflection object, krakjoe.

It is comparable in performance to the creation of other objects, sure, but it is too slow considered that reflection is basically just static information.

For instance, why is this 6 (!!!) times slower than creating the actual object?

class A{}

for($i = 0; $i < 1000000; $i++){
    new A();
} // 0.3150179386 seconds

for($i = 0; $i < 1000000; $i++){
    new ReflectionClass('A');
} // 1.9061090946 seconds
 [2016-05-23 20:20 UTC] dmri87 at hotmail dot com
The example would probably make more sense if I assigned the object to a variable. 

Also notice how I left out the constructor. I'd expect ReflectionClass to compare in performance to the creation of an object without calling its constructor.

Sorry for the multiple replies.
 [2016-05-29 04:22 UTC] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
 [2016-05-29 05:00 UTC] requinix@php.net
-Status: No Feedback +Status: Open
 [2016-05-29 10:04 UTC] nikic@php.net
The only obvious inefficiency in the ReflectionClass constructor is the population of the "name" property -- which will allocate and then destroy a temporary string. If we replace this with a persistent string we might get a 10% improvement there.

The difference between "new A" and "new ReflectionClass('A')" is that the latter has to perform a constructor call (expensive) and a runtime lookup of the class 'A' (expensive). This already accounts for most of the difference.

Some ctors like ReflectionProperty::__construct() could be optimized by using a union for different reflection object structures, rather than a separate allocation.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Mon Oct 14 09:01:26 2019 UTC