php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #71967 Regression "A non well formed numeric value encountered"
Submitted: 2016-04-05 13:36 UTC Modified: 2016-04-18 14:38 UTC
From: yunosh@php.net Assigned:
Status: Not a bug Package: *General Issues
PHP Version: master-Git-2016-04-05 (Git) OS: Linux
Private report: No CVE-ID: None
View Developer Edit
 [2016-04-05 13:36 UTC] yunosh@php.net 
Description:
------------
Not sure if https://github.com/php/php-src/commit/82050dfd3cba70b866da871fa7cc05232cfabf63 is the culprit, but a recent change in master raised a lot of "A non well formed numeric value encountered" in our test suite: https://travis-ci.org/horde/horde/jobs/120849452

Test script:
---------------
I couldn't strip it down to a short reproduce script, but this should do it:

pear install pear.horde.org/horde_image
cd /usr/share/php/test/Horde_Image/Horde/Image
phpunit .

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-04-05 22:07 UTC] nikic@php.net
-Status: Open +Status: Feedback
 [2016-04-05 22:07 UTC] nikic@php.net 
Please check whether the new warnings are expected as per https://wiki.php.net/rfc/invalid_strings_in_arithmetic.
 [2016-04-06 07:49 UTC] yunosh@php.net 
While debugging the issue, which is raised at https://github.com/horde/horde/blob/master/framework/Image/lib/Horde/Image/Exif/Base.php#L157 var_dump() reveals that the first two operands ($degrees and $minutes) are ints and the third ($seconds) is a float.
 [2016-04-07 12:37 UTC] ajf@php.net 
Are you sure you're using the PHP-7.0 branch ("7.0Git-2016-04-05 (Git)" is what you reported)? The numeric strings changes were merged into master, not PHP-7.0.
 [2016-04-07 12:45 UTC] yunosh@php.net
-PHP Version: 7.0Git-2016-04-05 (Git) +PHP Version: master-2016-04-05 (Git)
 [2016-04-07 12:45 UTC] yunosh@php.net 
Ah, no, sorry, this is on the master branch.
 [2016-04-07 12:46 UTC] yunosh@php.net
-PHP Version: master-2016-04-05 (Git) +PHP Version: master-Git-2016-04-05 (Git)
 [2016-04-07 13:30 UTC] ajf@php.net 
In that case, this is probably a result of the RFC.
 [2016-04-07 13:52 UTC] yunosh@php.net 
Rather "of an incorrect patch for that RFC".
 [2016-04-17 04:22 UTC] php-bugs at lists dot php dot net 
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
 [2016-04-17 08:18 UTC] pajoye@php.net
-Status: No Feedback +Status: Feedback
 [2016-04-17 08:18 UTC] pajoye@php.net 
Feedback given. Asking more :)

Would be very helpful to have examples showing which cases should be considered as wrong, self contained small examples.
 [2016-04-18 13:18 UTC] yunosh@php.net 
As I said below, I wasn't able to strip this down to a smaller use case. The problem is not the concept, but the implementation. There has to be some side-effect that only affects certain code paths.
 [2016-04-18 14:38 UTC] yunosh@php.net
-Status: Feedback +Status: Not a bug
 [2016-04-18 14:38 UTC] yunosh@php.net 
Looks like I didn't look closely enough when tracing the code path. This was some unexpected result from exif_read_data() instead. Must have been blind when I first encountered this, sorry for the noise.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun Dec 22 06:01:30 2024 UTC