php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #71350 Possible bugs and change requests about idna functions
Submitted: 2016-01-12 11:38 UTC Modified: -
From: nospampls at example dot org Assigned:
Status: Open Package: intl (PECL)
PHP Version: 7.0.2 OS:
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2016-01-12 11:38 UTC] nospampls at example dot org
Description:
------------
Firstly, not really important,
IDNA_NONTRANSITIONAL_TO_ASCII
IDNA_NONTRANSITIONAL_TO_UNICODE
should be merged into a single constant if possible.
The reason ICU have both is that IDNA configuration is shared for both encoding and decoding. PHP has two separate functions, one constant would be enough.

The constant DOMAIN_NAME_TOO_LONG doesn't look to be actually used ever. Since the functions just return false (without populating $info, when intl.exceptions is off) or throw a generic exception. I would suggest to always populate $info and include this error when intl.exceptions is off.

Same goes with idna_to_*("" /* empty string */, ..., ..., $info), rather than just returning false (and throw an exception if they are enabled), i would expect it to populate $info with the IDNA_ERROR_EMPTY_LABEL set (as happens with raw ICU).


Patches

Add a Patch

Pull Requests

Add a Pull Request

 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Tue Oct 22 14:01:27 2019 UTC