php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #71025 Compile failure with svn 1.9.x
Submitted: 2015-12-04 08:44 UTC Modified: 2016-03-29 04:42 UTC
Votes:2
Avg. Score:4.5 ± 0.5
Reproduced:2 of 2 (100.0%)
Same Version:0 (0.0%)
Same OS:0 (0.0%)
From: php-bugs-2015 at ryandesign dot com Assigned: alan_k (profile)
Status: Closed Package: svn (PECL)
PHP Version: 5.6.16 OS: OS X
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2015-12-04 08:44 UTC] php-bugs-2015 at ryandesign dot com 
Description:
------------
The svn pecl module version 1.0.2 does not compile with subversion 1.9.2, apr 1.5.2 and apr-util 1.5.4 on OS X 10.11. The first error is:


/opt/local/var/macports/build/_Users_rschmidt_macports_dports_php_php-svn/php56-svn/work/svn-1.0.2/svn.c:935:11: error: subscript of pointer to incomplete type 'svn_sort__item_t' (aka 'struct svn_sort__item_t')
                item = &APR_ARRAY_IDX (array, i, svn_sort__item_t);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/local/include/apr-1/apr_tables.h:141:57: note: expanded from macro 'APR_ARRAY_IDX'
#define APR_ARRAY_IDX(ary,i,type) (((type *)(ary)->elts)[i])
                                   ~~~~~~~~~~~~~~~~~~~~~^
/opt/local/include/subversion-1/svn_sorts.h:55:16: note: forward declaration of 'struct svn_sort__item_t'
typedef struct svn_sort__item_t svn_sort__item_t;
               ^

Patches

support-subversion-1.9.x (last revision 2016-03-23 10:19 UTC by pterjan at google dot com)
initial-support-of-subversion-1.9 (last revision 2016-03-18 02:18 UTC by pterjan at google dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-12-08 06:14 UTC] alan_k@php.net 
needs a patch.
 [2016-02-24 13:32 UTC] webmaster at ajeux dot com 
This error is not related to apr or OSX, I have the same error on Linux with PHP 5.5
This is only a matter of subversion version : SVN module does not compile anymore with subversion >= 1.9
 [2016-03-18 02:20 UTC] pterjan at google dot com 
I added a first patch, it is working but not the sorting so those lines are commented.
 [2016-03-23 10:20 UTC] pterjan at google dot com 
I have updated the patch, which is now complete and should offer same behaviour than the code had with older subversion.
I haven't tested against older subversion but I would expect it to still build fine.
 [2016-03-29 04:40 UTC] alan_k@php.net 
Automatic comment from SVN on behalf of alan_k
Revision: http://svn.php.net/viewvc/?view=revision&revision=338841
Log: fix for #71025 - supprt for subversion 1.9 by pterjan at google dot com
 [2016-03-29 04:42 UTC] alan_k@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: alan_k
 [2016-03-29 04:42 UTC] alan_k@php.net 
Nice fix using PHP's sort.

Commited

Thanks
Alan
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Wed Apr 24 02:01:30 2024 UTC