php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #70472 prevent trait to be used when conflicts can't be resolved
Submitted: 2015-09-10 19:34 UTC Modified: 2017-08-05 04:47 UTC
From: youwishspambot at example dot orgy Assigned:
Status: Suspended Package: Scripting Engine problem
PHP Version: 7.0.0RC2 OS: any
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2015-09-10 19:34 UTC] youwishspambot at example dot orgy
Description:
------------
Example 1:

<?php

class A{}
class B{}

trait X{
    abstract function test(B $b);
    function doSomething(){
        // can only be B. nothing should be allowed to change the signature of test(B)
        $this->test(new B);
    }
}

interface Contract{
    function test(A $a);
}

class Implementation implements Contract{
    use X; // incompatible, but compiles
    function test(A $a){}
}

-------------------------------------------------------

Example 2:

<?php

class A{}
class B{}

trait X{
    function tryA(A $a){
        $this->test($a);
    }
    function test(A $a){} // can't solve signatures incompatibility...
}

trait Y{
    function tryB(B $b){
        $this->test($b);
    }
    function test(B $b){} // ...when arguments are different
}


class Example{
    use X, Y{
        X::test insteadof Y; // this doesn't actually solve anything
    }
}

class A{}
class B{}

$x = new Example;
$x->tryA(new A);
$x->tryB(new B);

(insteadof can only work if resolution happens between two identical signatures)


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-09-10 19:46 UTC] stas@php.net
-Type: Bug +Type: Feature/Change Request -Package: PHP Language Specification +Package: Scripting Engine problem
 [2017-08-05 04:47 UTC] stas@php.net
-Status: Open +Status: Suspended
 [2017-08-05 04:47 UTC] stas@php.net
Thank you for your interest in PHP and for submitting a feature request. Please be aware that due to the magnitude of change this request requires, it would be necessary to discuss it on PHP Internals list (internals@lists.php.net) as an RFC. Please read the guide about creating RFCs here:
https://wiki.php.net/rfc/howto
If you haven't had experience with writing RFCs before, it is advised to seek guidance on the Internals list (http://php.net/mailing-lists.php) and/or solicit help from one of the experienced developers. 

Please to not consider this comment as a negative view on the merits of your proposal - every proposal which requires changes of certain magnitude, even the very successful and widely supported ones, must be done through the RFC process. This helps make the process predictable, transparent and accessible to all developers.
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Sun Nov 19 01:31:42 2017 UTC