php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #69718 Return values for magics can be nonsensical
Submitted: 2015-05-28 07:05 UTC Modified: 2015-05-28 07:06 UTC
Votes:3
Avg. Score:3.3 ± 1.7
Reproduced:1 of 2 (50.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: stas@php.net Assigned: stas (profile)
Status: Assigned Package: Scripting Engine problem
PHP Version: master-Git-2015-05-28 (Git) OS: *
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2015-05-28 07:05 UTC] stas@php.net
Description:
------------
Since we now allow defining return value types for functions, one can also create definition for magic functions that make no sense, such as __toString() : float or __isset() : Closure. I think we should restrict such definitions - either to types that makes sense or in case of methods that aren't supposed to return anything useful, completely. We already do this for ctors, dtors and __clone but not consistently for other magics.

Specifically, the following should be true:

__clone - no return type
__isset - only boolean allowed as return type
__sleep - only array allowed as return type
__set - no return type
__toString - only string allowed as return type
__wakeup - no return type

Also, may make sense to restrict argument types (of course, not typing is always ok):

__call/__callStatic - only string for first and array for second arguments
__get/__set/__isset/__unset - only string for the first argument

__set_state - only array is allowed as argument type




Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-05-28 07:06 UTC] stas@php.net
-Assigned To: +Assigned To: stas
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Sun Nov 19 01:31:42 2017 UTC