php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #69279 Compressed ZIP Phar extractTo() creates garbage files
Submitted: 2015-03-23 01:32 UTC Modified: 2015-08-02 21:53 UTC
Votes:4
Avg. Score:3.5 ± 1.7
Reproduced:2 of 2 (100.0%)
Same Version:0 (0.0%)
Same OS:1 (50.0%)
From: mario at include-once dot org Assigned:
Status: Verified Package: PHAR related
PHP Version: 5.6.7 OS: Linux/3.13/amd64
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2015-03-23 01:32 UTC] mario at include-once dot org
Description:
------------
See also #50797 - "PHAR fails to extract ZIP archives, but TAR is ok",
which seems to document the same issue.


Phar::extractTo() creates compressed/garbage output. Extracted files match the recorded file sizes. But they'll contain some binary content instead of the actual and decompressed file contents.

It seems extractTo slices out raw ZIP archive contents, 18 bytes after the stored filename of the local PK file header.


This behaviour isn't specific to 5.6.x, happened throughout 5.3, 5.4 and 5.5 too.
(Example run against 5.6.6-1~dotdeb.1/ZTS/amd64.)


An interesting workaround btw, is to use the phar:// streamwrapper prior. If a compressed file from the ZIP is accessed (per file_get_contents("phar://test.phar.zip/phar-test.txt") beforehand), then Phar::extractTo can reproduce the original file content.



Test script:
---------------
define('PHAR_FNAME', "test.phar.zip");
define('SAMPLE_FN',  "phar-test.txt");
define('SAMPLE_TXT', "Sample content.\n");

// Create ZIP+GZ-Phar
$w = new Phar(PHAR_FNAME);
$w[SAMPLE_FN] = SAMPLE_TXT;
$w->compressFiles(Phar::GZ);

// Open anew
$r = new Phar(PHAR_FNAME);
assert($r[SAMPLE_FN]->isCompressed());

// Extract to file and compare to sample: fails
$r->extractTo(".", NULL, TRUE);
assert(SAMPLE_TXT === file_get_contents(SAMPLE_FN));


Expected result:
----------------
Example `test.phar.zip`

UEsDBAAAAAAIAPIOd0a3HaQhEgAAABAAAAANABIAcGhhci10ZXN0LnR4dG51DgBXK0GEtg
EAAAAAAAAAAAtOzC3ISVVIzs8rSc0r0eMCAFBLAwQAAAAACADyDndGmVatcj4AAAA8AAAA
DgASAC5waGFyL3N0dWIucGhwbnUOAFcrQYS2AQAAAAAAAAAAs7EvyChQ0NdXqMos0E1KLE
5NUSjISCxSSCxKzsgsS1UoLilNUkjLzEnlio/3cPQJiXf29w3w9HEN0tC0BgBQSwMEAAAA
AAAAAAgh7IqfoyccAAAAHAAAABMAEgAucGhhci9zaWduYXR1cmUuYmlubnUOAP8S2UEAAA
AAAAAAAAAAAgAAABQAAAC/Ml0QwRjS2lNjdmUVA5Z1AsltwFBLAQIAAAAAAAAIAPIOd0a3
HaQhEgAAABAAAAANABIAAAAAAAAAAAAAAAAAAABwaGFyLXRlc3QudHh0bnUOAFcrQYS2AQ
AAAAAAAAAAUEsBAgAAAAAAAAgA8g53RplWrXI+AAAAPAAAAA4AEgAAAAAAAAAAAAAATwAA
AC5waGFyL3N0dWIucGhwbnUOAFcrQYS2AQAAAAAAAAAAUEsBAgAAAAAAAAAAAAgh7Iqfoy
ccAAAAHAAAABMAEgAAAAAAAAAAAAAAywAAAC5waGFyL3NpZ25hdHVyZS5iaW5udQ4A/xLZ
QQAAAAAAAAAAAABQSwUGAAAAAAMAAwDuAAAAKgEAAAAA


Actual result:
--------------
The "Sample content.\n" from `test-phar.txt` gets created as:

 4e0b2dcc49c84855cfce492b2bcde3d1  N�-�IUH��+I�+�



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-08-02 21:50 UTC] stas@php.net
-Status: Open +Status: Verified
 [2015-08-02 21:53 UTC] stas@php.net
PharData has the same problem (probably the same code) - this code on a zip file:

<?php
    $phar = new PharData('TestFile.zip');
    $phar->extractTo('test');

when TestFile.zip contains text files, produces garbage files as a result. Looks like Phar fogets to uncompress the data or something like that.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Mon Apr 22 08:01:25 2019 UTC