php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #69140 FILTER_VALIDATE_EMAIL should accept user@localhost
Submitted: 2015-02-27 17:02 UTC Modified: 2016-11-24 07:43 UTC
Votes:3
Avg. Score:4.3 ± 0.9
Reproduced:3 of 3 (100.0%)
Same Version:1 (33.3%)
Same OS:1 (33.3%)
From: info at linux-web-development dot de Assigned:
Status: Open Package: Filter related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2015-02-27 17:02 UTC] info at linux-web-development dot de
Description:
------------
When trying to validate an e-mail address using FILTER_VALIDATE_EMAIL will result in several problems with correct mail addresses. So far I could find the following compliant addresses not validating:

foo@example
foo@(bar)example.com
foo@example.com(bar)

Generally PHP should at comply with RFC 822 when validating mail addresses, otherwise the filter function is useless.

Test script:
---------------
var_dump(filter_var('foo@example', FILTER_VALIDATE_EMAIL));

Expected result:
----------------
string(11) "foo@example"


Actual result:
--------------
bool(false)

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-02-27 20:46 UTC] aharvey@php.net
The code does actually document that comments aren't handled, but that never made it to the docs. I'll fix that.

I don't think this is worth fixing (the validation code is terrifying enough as it is, and, seriously, comments in e-mail addresses?), but I'll leave this open in case someone can provide a clean PR.
 [2015-02-27 20:50 UTC] aharvey@php.net
Automatic comment from SVN on behalf of aharvey
Revision: http://svn.php.net/viewvc/?view=revision&revision=336016
Log: Expand on what FILTER_VALIDATE_EMAIL really validates.

See also bug #69140 (FILTER_VALIDATE_EMAIL not RFC 822 compliant).
 [2015-03-01 18:18 UTC] info at linux-web-development dot de
The docs are still not correct. The PHP validation is just wrong in more ways than just comments. e.g. the domain part could be a hostname without a dot, but this always comes back as false. This has real applications, e.g. under Linux when sending to [user]@localhost

There is a reason frameworks don't use this built-in function but instead resort to their own validation for e-mails. So this function should either be clearly marked as non-RFC-compatible or just work as one would expect it to work. Sorry, but not fixing this because it's hard to implement is just a lame excuse. Implement it or leave it out, but don't implement some half-working frankenvalidation.
 [2015-03-02 00:16 UTC] ppaisndud at gmail dot com
I did a bit of fixing and this could be a patch, strict to RFC 822 

https://github.com/pasindud/php-src/commit/ec209d5add25322122e10e18261f0ae5fa7a57cf

Some Issuses

RFC 822 - is obsolete in 2001 by 2822, 5322
RFC 2822 - is obsolete in 2008 by 5322,5321 (both of those also have conflicts)
 [2016-11-21 17:02 UTC] cmb@php.net
-Summary: FILTER_VALIDATE_EMAIL not RFC 822 compliant +Summary: FILTER_VALIDATE_EMAIL does not accept user@localhost -Type: Bug +Type: Feature/Change Request
 [2016-11-21 17:02 UTC] cmb@php.net
> The PHP validation is just wrong in more ways than just
> comments. e.g. the domain part could be a hostname without a
> dot, but this always comes back as false.

This is a deliberate decision to avoid issues with RFC 5321[1], so
simply changing the behavior would cause issues. Introducing a new
flag appears to be the most reasonable solution, so I'm changing
to feature request, leaving the documentation part to bug #66553.

[1] <https://github.com/php/php-src/blob/PHP-7.0.13/ext/filter/logical_filters.c#L579-L588>
 [2016-11-21 17:02 UTC] cmb@php.net
-Summary: FILTER_VALIDATE_EMAIL does not accept user@localhost +Summary: FILTER_VALIDATE_EMAIL should accept user@localhost
 [2016-11-22 12:12 UTC] bugs-php-net at unikorn dot me
I'm sorry, but did you seriously just change the whole topic because you can't differentiate between the RFCs for emails and their address format and a transport protocol for them?

The original bug clearly stated that there are different standards-compliant email addresses that won't work with PHPs filter_var, not only one. I'm not sure why PHP developers are this, but out in the real world, not being standards-compliant is a bug.
 [2016-11-24 07:43 UTC] yohgaki@php.net
I understand there is use case for user@localhost. However, accepting user@localhost (or user@hostnameonly) is problematic for most applications.

Therefore, there should be additional flag for it. Problems is all flags, i.e. flag is bit flag, is used already. We can reuse some bits, though.

IMHO, current filter module's validation feature is incomplete and unusable. Instead of adding specific rare usage, it's better to have generic and extensible validator such as
https://wiki.php.net/rfc/add_validate_functions_to_filter
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Tue Mar 26 16:01:26 2019 UTC