php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #68704 incorrect parenthesis
Submitted: 2014-12-31 09:13 UTC Modified: -
From: honey at internot dot info Assigned:
Status: Closed Package: PCRE related
PHP Version: master-Git-2014-12-31 (Git) OS: Linux Ubuntu 14.04
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2014-12-31 09:13 UTC] honey at internot dot info 
Description:
------------
Hi,

In php_pcre.c on L379:

378        if (BG(locale_string) &&
379            (!BG(locale_string)->len != 1 || !BG(locale_string)->val[0] != 'C')) 

It should probably be:

!(BG(locale_string)->len != 1) || [..]

or something like that.

Either way, it's incorrect checking in both ways.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-01-08 08:38 UTC] laruence@php.net 
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d7fd9406915e3b8cf66764305e82b0cae2414545
Log: Fixed #68704
 [2015-01-08 08:38 UTC] laruence@php.net
-Status: Open +Status: Closed
 [2016-07-20 11:40 UTC] davey@php.net 
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d7fd9406915e3b8cf66764305e82b0cae2414545
Log: Fixed #68704
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Apr 20 00:01:27 2024 UTC