|  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #67219 Version 1.3.1 does not compile
Submitted: 2014-05-06 15:20 UTC Modified: 2014-05-06 15:56 UTC
From: saprykin dot dmitry at gmail dot com Assigned: tony2001 (profile)
Status: Closed Package: sphinx (PECL)
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2014-05-06 15:20 UTC] saprykin dot dmitry at gmail dot com
My sphinxclient.h content is:

/// known ranking modes (ext2 only)
        SPH_RANK_PROXIMITY_BM25 = 0,
        SPH_RANK_BM25                   = 1,
        SPH_RANK_NONE                   = 2,
        SPH_RANK_WORDCOUNT              = 3

This causes wrong match for pattern in config.m4 function SPHINX_CHECK_ENUM with string "SPH_RANK_PROXIMITY_BM25 = 0". So ./configure defines constant HAVE_SPH_RANK_PROXIMITY by mistake.
Nevertheless regex will match even commented out strings. May be it is better to use AC_TRY_COMPILE?


sphinx_67219.diff (last revision 2014-05-06 15:54 UTC by
sph-rank-const-fix (last revision 2014-05-06 15:20 UTC by saprykin dot dmitry at gmail dot com)

Add a Patch

Pull Requests

Add a Pull Request


AllCommentsChangesGit/SVN commitsRelated reports
 [2014-05-06 15:54 UTC]
The following patch has been added/updated:

Patch Name: sphinx_67219.diff
Revision:   1399391674
 [2014-05-06 15:56 UTC]
-Status: Open +Status: Assigned -Assigned To: +Assigned To: tony2001
 [2014-05-06 15:56 UTC]
I was actually trying to avoid TRY_COMPILE because running a compiler might be quite slow and doing it for every constant in a enum looks to me as an overkill.
But it seems that you're right and I'll have to do it after all.
Could you please try mu version of your patch?
The one you attached failed to find any of the constants.

You might also want to update your Sphinx, btw =)
 [2014-05-06 16:11 UTC] saprykin dot dmitry at gmail dot com
Thanks a lot!
Your version of patch works just fine.
 [2014-05-06 16:26 UTC]
Automatic comment on behalf of
Log: fix bug #67219 (Version 1.3.1 does not compile)
 [2014-05-06 16:26 UTC]
-Status: Assigned +Status: Closed
PHP Copyright © 2001-2023 The PHP Group
All rights reserved.
Last updated: Sun Jan 29 16:05:54 2023 UTC