php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #66858 SolrParams: Throw SolrIllegalArgumentException instead of E_ERROR
Submitted: 2014-03-09 01:32 UTC Modified: 2014-03-09 01:51 UTC
From: omars@php.net Assigned: omars (profile)
Status: Closed Package: solr (PECL)
PHP Version: Irrelevant OS: All
Private report: No CVE-ID: None
 [2014-03-09 01:32 UTC] omars@php.net
Description:
------------
It would be better to throw SolrIllegalArgumentException instead of E_ERROR while setting invalid parameters, using SolrParams and its descendents.

Test script:
---------------
$query = new SolrQuery();
$query->setQuery('');
// or 
$params = new SolrModifiableParams();
$params->addParam('',1);

Expected result:
----------------
Fatal error: Uncaught exception 'SolrIllegalArgumentException' with message 'Invalid parameter value'

Actual result:
--------------
Fatal error: SolrQuery::setQuery(): Invalid parameter value 

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-03-09 01:51 UTC] omars@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: omars
 [2014-03-09 01:51 UTC] omars@php.net
-Status: Assigned +Status: Closed
 [2014-03-09 01:51 UTC] omars@php.net
fixed on master
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Mon May 06 13:01:31 2024 UTC