php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #66555 Always false condition in ext/gd/libgd/gdkanji.c
Submitted: 2014-01-22 20:08 UTC Modified: -
From: mathew1800 at gmail dot com Assigned:
Status: Closed Package: GD related
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID:
 [2014-01-22 20:08 UTC] mathew1800 at gmail dot com
Description:
------------
See: https://github.com/php/php-src/blob/master/ext/gd/libgd/gdkanji.c#L333

You should see the lines:

  if (daku)
    {
      if ((*p2 >= 74 && *p2 <= 103) || (*p2 >= 110 && *p2 <= 122))
        (*p2)++;
      else if (*p2 == 131 && *p2 == 69)
        *p2 = 148;
    }

"else if (*p2 == 131 && *p2 == 69)" will always be false.

Test script:
---------------
Not necessary


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-07-23 15:11 UTC] cmb@php.net
Automatic comment on behalf of cmb
Revision: http://git.php.net/?p=php-src.git;a=commit;h=2c16b9cf62072afefb9a318f4a503bb9335f8537
Log: Fix #66555: Always false condition in ext/gd/libgd/gdkanji.c
 [2016-07-23 15:11 UTC] cmb@php.net
-Status: Open +Status: Closed
 [2016-10-17 10:10 UTC] bwoebi@php.net
Automatic comment on behalf of cmb
Revision: http://git.php.net/?p=php-src.git;a=commit;h=2c16b9cf62072afefb9a318f4a503bb9335f8537
Log: Fix #66555: Always false condition in ext/gd/libgd/gdkanji.c
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Thu Jul 20 18:01:35 2017 UTC