php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Doc Bug #66366 Undocumented breaking change, when upgrading from php 5.3
Submitted: 2013-12-29 04:11 UTC Modified: 2017-03-13 10:23 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:0 (0.0%)
Same OS:0 (0.0%)
From: markuwil at gmail dot com Assigned: narf (profile)
Status: Closed Package: *Encryption and hash functions
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2013-12-29 04:11 UTC] markuwil at gmail dot com 
Description:
------------
---
From manual page: http://www.php.net/migration54.incompatible
---

Re: https://bugs.php.net/bug.php?id=61291 and fix regarding Tiger hashes.

This was never documented as a breaking change, when upgrading from 5.3. Also the only changelog entry related to it cites big endian when the Tiger paper explicitly states little endian. I have no insight into whether the changelog entry is correct or not but a Tiger hash is little endian whereas php used to output it in big endian.

To actually get to the root of all of this, one has to, in the worst case, find five years old reports and then find that they have suddenly been fixed (after first being marked as 'Not a bug', which implies in-action) without so much as a note in documentation for hash nor mhash (both of which have suffered from this at one time or another).

Obviously this is breaking change by proxy for anyone who does not know the Tiger specification (and even appears a bug to anyone who reads Wikipedia, but that is irrelevant to php) or has relied on the old behavior as correct, to generate, store or compare against hashes such hashes.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-12-29 04:40 UTC] bjori@php.net
-Status: Open +Status: Verified
 [2013-12-29 04:40 UTC] bjori@php.net 
http://us3.php.net/manual/en/function.hash.php#refsect1-function.hash-changelog

Although, you are right, it should have been in the incompatible section too.
 [2017-03-13 10:19 UTC] narf@php.net 
Automatic comment from SVN on behalf of narf
Revision: http://svn.php.net/viewvc/?view=revision&revision=342107
Log: Fix docs bug #66366: Tiger hash BC not documented in migration54
 [2017-03-13 10:23 UTC] narf@php.net
-Status: Verified +Status: Closed -Assigned To: +Assigned To: narf
 [2017-03-13 10:23 UTC] narf@php.net 
The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.

Added an entry about this to migration54.incompatible
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 26 11:01:31 2024 UTC