php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #64850 Extra whitespace before function links
Submitted: 2013-05-15 21:35 UTC Modified: 2013-12-30 06:58 UTC
From: salathe@php.net Assigned: bjori (profile)
Status: Closed Package: Doc Build problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
If you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: salathe@php.net
New email:
PHP Version: OS:

 

 [2013-05-15 21:35 UTC] salathe@php.net
Description:
------------
When rendering <function> tags, a space is added before the anchor tag.
This was a deliberate choice (see comment below) but affects areas other
than the function/method synopsis.

The Package_PHP_XHTML::format_function() method says:
    // Leading space intional for methodname as phpdoc doesn't have a
    // space between <type> and the <methodname> in methodsynopsis

However, this affects other uses of <methodname> and <function> and is 
particularly noticeable when the function name is written in parentheses. 

Examples:

    mysql_pconnect:
    "for future use ( mysql_close() will not close links"

    mysqlnd.stats:
    "from COM_LIST_FIELD ( mysql_list_fields()) and the"

    ldap_control_paged_results:
    "sent by the server ( ldap_control_paged_result_response())."

The leading space should be removed. Instead, a space should be added
to the rendered HTML only where it is needed: after rendering the
<type>, before a <methodname>, in a <methodsynopsis>.


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-05-15 21:46 UTC] salathe@php.net
Quick patch submitted as Pull Request: https://github.com/php/phd/pull/2
 [2013-12-30 06:58 UTC] bjori@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: bjori
 [2013-12-30 06:58 UTC] bjori@php.net
The fix for this bug has been committed. Since the websites are not directly
updated from the repository, the fix might need some time to spread
across the globe to all mirror sites, including PHP.net itself.

Thank you for the report, and for helping us make PHP.net better.

Sorry.. Don't know why I haven't looked at this category for 6months.. pulled now atleast.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Oct 04 14:01:27 2024 UTC