php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #64562 rarentry.c:183:17: error: too few arguments to function call
Submitted: 2013-04-02 07:26 UTC Modified: 2013-04-03 14:27 UTC
From: php-bugs-2013 at ryandesign dot com Assigned: tony2001 (profile)
Status: Closed Package: rar (PECL)
PHP Version: 5.5.0beta1 OS: OS X 10.8.3
Private report: No CVE-ID: None
 [2013-04-02 07:26 UTC] php-bugs-2013 at ryandesign dot com
Description:
------------
Building the rar pecl module with php 5.5.0beta1 and 5.5.0beta2 fails:


rarentry.c:183:17: error: too few arguments to function call, expected 4, have 3
                NULL TSRMLS_CC);
                              ^
1 error generated.
make: *** [rarentry.lo] Error 1


It built successfully using an earlier alpha version of php 5.5.0.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-04-02 08:05 UTC] tony2001@php.net
Plz try this patch: https://gist.github.com/tony2001/5290671
It's a little bit oversized, but at least we won't have to adjust the code everytime the 
API changes (I hope).
 [2013-04-02 08:05 UTC] tony2001@php.net
-Status: Open +Status: Feedback
 [2013-04-02 10:38 UTC] php-bugs-2013 at ryandesign dot com
-Status: Feedback +Status: Open
 [2013-04-02 10:38 UTC] php-bugs-2013 at ryandesign dot com
Thanks, that works.

But the patch did not apply cleanly. This chunk did not apply:



***************
*** 754,760 ****
  			if ((*archive = expand_filepath(tmp_archive, NULL TSRMLS_CC))
  					== NULL) {
  				php_stream_wrapper_log_error(wrapper, options TSRMLS_CC,
- 					"Could not expand the path %s", archive);
  				goto cleanup;
  			}
  		}
--- 754,760 ----
  			if ((*archive = expand_filepath(tmp_archive, NULL TSRMLS_CC))
  					== NULL) {
  				php_stream_wrapper_log_error(wrapper, options TSRMLS_CC,
+ 					"Could not expand the path %s", *archive);
  				goto cleanup;
  			}
  		}



In the 3.0.1 code, the error message does not use "archive" but 
"tmp_archive". Yet another difference between the code in the 
repository (whose php_rar.h says it's version 3.0.0) and the 
code that was released on pecl as 3.0.1 last year. You should 
get all the changes that were made for 3.0.1 into the 
repository so that 3.0.2 or whatever you release next does not 
reintroduce all the problems you fixed for 3.0.1:

http://pecl.php.net/package-changelog.php?package=rar&release=3.0.1
 [2013-04-02 11:33 UTC] tony2001@php.net
The diff is against trunk, not 3.0.1, so it's ok.
Ok, I'll try to catch up with Gustavo or commit it myself today..
 [2013-04-02 11:33 UTC] tony2001@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: tony2001
 [2013-04-03 14:27 UTC] tony2001@php.net
The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 [2013-04-03 14:27 UTC] tony2001@php.net
-Status: Assigned +Status: Closed
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Sun Jan 19 08:01:23 2020 UTC