php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #64362 Reject this patch does not close modal dialog
Submitted: 2013-03-05 20:56 UTC Modified: 2013-03-09 10:22 UTC
From: salathe@php.net Assigned: yannick (profile)
Status: Closed Package: Online Doc Editor problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2013-03-05 20:56 UTC] salathe@php.net
Description:
------------
When reviewing patches, the "Anonymous patch manager" dialog box [1] is 
presented. Choosing "Reject this patch" and clicking "Next" results in the file 
being rejected and rolled back successfully, but the dialog box is not removed 
from the screen.

Hitting "Next" again confirms that the rejection happend since an alert is 
presented saying "The file you want to clear local changes in doesn't exist as a 
work in progress." However, the dialog box remains on the screen.

Since it is a modal dialog, the rest of the interface in inaccessible.

The whole page must be refreshed, reloading the editor.

Expected result:
----------------
Maybe some confirmation that the file was rolled back. And the dialog should be 
closed.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-03-09 10:21 UTC] yannick@php.net
Automatic comment on behalf of yannick.torres@gmail.com
Revision: http://git.php.net/?p=web/doc-editor.git;a=commit;h=4e3f3b174d668ae0229d50f20bf08044de1abe96
Log: Fix bug #64362 : Modal window is now close when we choose to reject a patch in the anonymous patch manager. We also add a confirm dialog since the action is irreversible. We also add some pixel's height for this window to fix height issue with some UI translation.
 [2013-03-09 10:21 UTC] yannick@php.net
-Status: Open +Status: Closed
 [2013-03-09 10:22 UTC] yannick@php.net
-Assigned To: +Assigned To: yannick
 [2013-03-09 10:22 UTC] yannick@php.net
This bug has been fixed in SVN, and should show up online in an
hour or three.

Thank you for the report, and for helping us make PHP.net better.

Thanks salathe for the report ;)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sun May 05 21:01:30 2024 UTC